You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jake Farrell (JIRA)" <ji...@apache.org> on 2012/09/28 13:41:08 UTC

[jira] [Closed] (THRIFT-1571) Update Ruby HTTP transport for recent Ruby versions

     [ https://issues.apache.org/jira/browse/THRIFT-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell closed THRIFT-1571.
--------------------------------

       Resolution: Not A Problem
    Fix Version/s: 0.9
         Assignee: Jake Farrell

Current trunk all ready has a variant of this patch in it

<code>
  resp = http.post(@url.request_uri, @outbuf, @headers)
  data = resp.body
  @inbuf = StringIO.new data
  @outbuf = ""
</code>

                
> Update Ruby HTTP transport for recent Ruby versions
> ---------------------------------------------------
>
>                 Key: THRIFT-1571
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1571
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.8
>            Reporter: Seth Hitchings
>            Assignee: Jake Farrell
>             Fix For: 0.9
>
>         Attachments: thrift-1571.patch
>
>
> Net::HTTP.post no longer returns the HTTP response body string as a second return value. From http://ruby-doc.org/stdlib-1.8.7/libdoc/net/http/rdoc/Net/HTTP.html:
> "In version 1.1 (ruby 1.6), this method returns a pair of objects, a Net::HTTPResponse object and an entity body string. In version 1.2 (ruby 1.8), this method returns a Net::HTTPResponse object."
> The attached patch modifies http_client_transport.rb to get the response body from the returned Net::HTTPResponse object instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira