svn commit: r1154706 - /httpd/httpd/trunk/modules/aaa/mod_authz_host.c

[co...@apache.org]

Author: covener
Date: Sun Aug  7 14:07:19 2011
New Revision: 1154706

URL: http://svn.apache.org/viewvc?rev=1154706&view=rev
Log:
PR46214: axe some misleading DEBUG messages in mod_authz_host.  

Access is not necessarily denied because a single requirement failed to grant 
access, and mod_authz_core is already reporting at DEBUG the require line and 
the providers result.

Elaborate on one remaining legitimate message to include the require line.


Modified:
    httpd/httpd/trunk/modules/aaa/mod_authz_host.c

Modified: httpd/httpd/trunk/modules/aaa/mod_authz_host.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_authz_host.c?rev=1154706&r1=1154705&r2=1154706&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/mod_authz_host.c (original)
+++ httpd/httpd/trunk/modules/aaa/mod_authz_host.c Sun Aug  7 14:07:19 2011
@@ -158,11 +158,7 @@ static authz_status ip_check_authorizati
         ip++;
     }
 
-    ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r,
-                  "access to %s failed, reason: ip address list does not meet "
-                  "'require'ments for user '%s' to be allowed access",
-                  r->uri, r->user);
-
+    /* authz_core will log the require line and the result at DEBUG */
     return AUTHZ_DENIED;
 }
 
@@ -181,8 +177,8 @@ static authz_status host_check_authoriza
 
     if ((remotehost == NULL) || remotehost_is_ip) {
         ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
-                      "access to %s failed, reason: unable to get the "
-                      "remote host name", r->uri);
+                      "access check of '%s' to %s failed, reason: unable to get the "
+                      "remote host name", require_line, r->uri);
     }
     else {
         /* The 'host' provider will allow the configuration to specify a list of
@@ -194,13 +190,9 @@ static authz_status host_check_authoriza
                 return AUTHZ_GRANTED;
             }
         }
-
-        ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r,
-                      "access to %s failed, reason: host name list does not meet "
-                      "'require'ments for user '%s' to be allowed access",
-                      r->uri, r->user);
     }
 
+    /* authz_core will log the require line and the result at DEBUG */
     return AUTHZ_DENIED;
 }