You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/02/04 22:55:59 UTC
[jira] Created: (THRIFT-312) Ruby unit tests fail due to change in
BinaryProtocolAccelerated interface
Ruby unit tests fail due to change in BinaryProtocolAccelerated interface
-------------------------------------------------------------------------
Key: THRIFT-312
URL: https://issues.apache.org/jira/browse/THRIFT-312
Project: Thrift
Issue Type: Bug
Components: Library (Ruby)
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
It looks like the unit tests exercise BinaryProtocolAccelerated in the old way still, using encode_binary and decode_binary, rather than the standard interface methods, post THRIFT-248.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-312) Ruby unit tests fail due to change in
BinaryProtocolAccelerated interface
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-312.
----------------------------------
Resolution: Fixed
Committed.
> Ruby unit tests fail due to change in BinaryProtocolAccelerated interface
> -------------------------------------------------------------------------
>
> Key: THRIFT-312
> URL: https://issues.apache.org/jira/browse/THRIFT-312
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-312.patch
>
>
> It looks like the unit tests exercise BinaryProtocolAccelerated in the old way still, using encode_binary and decode_binary, rather than the standard interface methods, post THRIFT-248.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-312) Ruby unit tests fail due to change in
BinaryProtocolAccelerated interface
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-312:
---------------------------------
Patch Info: [Patch Available]
> Ruby unit tests fail due to change in BinaryProtocolAccelerated interface
> -------------------------------------------------------------------------
>
> Key: THRIFT-312
> URL: https://issues.apache.org/jira/browse/THRIFT-312
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-312.patch
>
>
> It looks like the unit tests exercise BinaryProtocolAccelerated in the old way still, using encode_binary and decode_binary, rather than the standard interface methods, post THRIFT-248.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-312) Ruby unit tests fail due to change in
BinaryProtocolAccelerated interface
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-312:
---------------------------------
Attachment: thrift-312.patch
It's been a while since I looked at this issue, so I'm not sure from the description what the problem was. The only thing I could find was that there's a lot of commented out test code that isn't needed anymore in the BinaryProtocolAccelerated spec. This patch removes that commented out code.
If no one objects, I will commit and close this issue.
> Ruby unit tests fail due to change in BinaryProtocolAccelerated interface
> -------------------------------------------------------------------------
>
> Key: THRIFT-312
> URL: https://issues.apache.org/jira/browse/THRIFT-312
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-312.patch
>
>
> It looks like the unit tests exercise BinaryProtocolAccelerated in the old way still, using encode_binary and decode_binary, rather than the standard interface methods, post THRIFT-248.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.