You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/05/05 16:28:09 UTC
[GitHub] [arrow] jorisvandenbossche opened a new pull request, #35449: GH-35448: [C++] Fix detection of %z in strptime format
jorisvandenbossche opened a new pull request, #35449:
URL: https://github.com/apache/arrow/pull/35449
### Rationale for this change
See gh-35448 for the failing example. The current code in `GetZone` was assuming there was always some character between the `%z` and the preceding `%` code (like a whitespace, or `-` or `/`). That is often not the case with `%z` (in time formats like `00:00+01`, the `+` is part of `%z`, and so the format is `%H:%M%z` without character between `%M` and `%z`)
### Are these changes tested?
Test is added
### Are there any user-facing changes?
The result type will no now correctly have a `tz=UTC` parametrization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35449: GH-35448: [C++] Fix detection of %z in strptime format
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35449:
URL: https://github.com/apache/arrow/pull/35449#issuecomment-1536496072
:warning: GitHub issue #35448 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35449: GH-35448: [C++] Fix detection of %z in strptime format
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35449:
URL: https://github.com/apache/arrow/pull/35449#issuecomment-1553868003
Benchmark runs are scheduled for baseline = 7fd64613ec9b7082d509695ef9542b0bfb4e2dbd and contender = 0980dbe330b77cf17fa2a2bb65eba43a992cfd68. 0980dbe330b77cf17fa2a2bb65eba43a992cfd68 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0d3edbda453244739b79368805e2dc6a...cd28e9fdab02462ab4a42c3ac108f9ba/)
[Finished :arrow_down:0.58% :arrow_up:0.15%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4e7bc4a961644e54bda5cc9b13219103...8f96f354591145a397a9f0780cef5352/)
[Finished :arrow_down:2.54% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8ae1b518661e4c2886cb7cd7b4d749a1...b3d80f5350cf42d3bfb96ac89366f982/)
[Finished :arrow_down:0.36% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/77aa2e434d15404792aab289b192ab88...bb74cc8813004871bd00a95a972c66a2/)
Buildkite builds:
[Finished] [`0980dbe3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2881)
[Finished] [`0980dbe3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2917)
[Finished] [`0980dbe3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2882)
[Finished] [`0980dbe3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2907)
[Finished] [`7fd64613` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2879)
[Finished] [`7fd64613` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2916)
[Finished] [`7fd64613` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2881)
[Finished] [`7fd64613` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2906)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35449: GH-35448: [C++] Fix detection of %z in strptime format
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35449:
URL: https://github.com/apache/arrow/pull/35449#issuecomment-1553869084
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8ae1b518661e4c2886cb7cd7b4d749a1...b3d80f5350cf42d3bfb96ac89366f982/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35449: GH-35448: [C++] Fix detection of %z in strptime format
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35449:
URL: https://github.com/apache/arrow/pull/35449#discussion_r1186472408
##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -1900,6 +1900,12 @@ TYPED_TEST(TestStringKernels, StrptimeZoneOffset) {
StrptimeOptions options("%m/%d/%Y %z", TimeUnit::MICRO, /*error_is_null=*/true);
this->CheckUnary("strptime", input1, timestamp(TimeUnit::MICRO, "UTC"), output1,
&options);
Review Comment:
Could you append `1` to `options` (`options1`) for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35449: GH-35448: [C++] Fix detection of %z in strptime format
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35449:
URL: https://github.com/apache/arrow/pull/35449#issuecomment-1536496032
* Closes: #35448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #35449: GH-35448: [C++] Fix detection of %z in strptime format
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #35449:
URL: https://github.com/apache/arrow/pull/35449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org