You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2017/08/08 21:14:18 UTC

[GitHub] spark pull request #18519: [SPARK-16742] Mesos Kerberos Support

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18519#discussion_r132032720
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -680,6 +686,18 @@ object SparkSubmit extends CommandLineUtils {
         (childArgs, childClasspath, sysProps, childMainClass)
       }
     
    +  // [SPARK-20328]. HadoopRDD calls into a Hadoop library that fetches delegation tokens with
    +  // renewer set to the YARN ResourceManager.  Since YARN isn't configured in Mesos mode, we
    +  // must trick it into thinking we're YARN.
    +  private def setRMPrincipal(sysProps: HashMap[String, String]): Unit = {
    +    val shortUserName = UserGroupInformation.getCurrentUser.getShortUserName
    +    val key = s"spark.hadoop.${YarnConfiguration.RM_PRINCIPAL}"
    +    // scalastyle:off println
    +    printStream.println(s"Setting ${key} to ${shortUserName}")
    --- End diff --
    
    Do you want this to be printed out every time someone runs spark-submit? Sounds a bit noisy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org