You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/24 10:50:23 UTC
[GitHub] [flink] vahmed-hamdy opened a new pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
vahmed-hamdy opened a new pull request #18468:
URL: https://github.com/apache/flink/pull/18468
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request adds SQL uber-jar for `KinesisStreams` table api and a respective end to end test to test it.
## Brief change log
- Created new shading module `flink-sql-connector-aws-kinesis-data-streams` that shades `flink-connector-kinesis-data-streams` and required dependencies.
- Created `flink-end-to-end-kinesis-tests` module to add a new end to end test that depend on the new sql connector.
## Verifying this change
This change added tests and can be verified as follows:
- Added `KinesisDataStreamsTableApiIT` end to end test for the new sql connector.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive):no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper:no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1022981278
Thanks @vahmed-hamdy, merged.
I also manually tested and found a couple of issues, unrelated to this change that I will raise Jiras for:
- Invalid credential provider configuration does not fail the job. Job ends up spinning.
- Sink does not react to cancellation signal. Interrupt is retried and job gets stuck in cancelling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
}, {
"hash" : "448450417bf411ac2b7de95792c4297cc42250a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30147",
"triggerID" : "448450417bf411ac2b7de95792c4297cc42250a9",
"triggerType" : "PUSH"
}, {
"hash" : "c9ca1ae40dd0845541df78dc73eb6cad2a227ad6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c9ca1ae40dd0845541df78dc73eb6cad2a227ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ac66f07be10e8c320e77b89e41fc6ba17b1571e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069)
* 448450417bf411ac2b7de95792c4297cc42250a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30147)
* c9ca1ae40dd0845541df78dc73eb6cad2a227ad6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18468:
URL: https://github.com/apache/flink/pull/18468#discussion_r793347912
##########
File path: flink-connectors/flink-sql-connector-aws-kinesis-data-streams/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,49 @@
+flink-sql-connector-aws-kinesis-data-streams
+
+Copyright 2014-2021 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- software.amazon.awssdk:kinesis:2.17.52
+- software.amazon.awssdk:aws-cbor-protocol:2.17.52
+- software.amazon.awssdk:aws-json-protocol:2.17.52
+- software.amazon.awssdk:protocol-core:2.17.52
+- software.amazon.awssdk:profiles:2.17.52
+- software.amazon.awssdk:sdk-core:2.17.52
+- software.amazon.awssdk:auth:2.17.52
+- software.amazon.eventstream:eventstream:1.0.1
+- software.amazon.awssdk:http-client-spi:2.17.52
+- software.amazon.awssdk:regions:2.17.52
+- software.amazon.awssdk:annotations:2.17.52
+- software.amazon.awssdk:utils:2.17.52
+- software.amazon.awssdk:aws-core:2.17.52
+- software.amazon.awssdk:metrics-spi:2.17.52
+- software.amazon.awssdk:apache-client:2.17.52
+- software.amazon.awssdk:netty-nio-client:2.17.52
+- software.amazon.awssdk:sts:2.17.52
+- software.amazon.awssdk:aws-query-protocol:2.17.52
+- software.amazon.awssdk:json-utils:2.17.52
+- software.amazon.awssdk:third-party-jackson-core:2.17.52
+- software.amazon.awssdk:third-party-jackson-dataformat-cbor:2.17.52
+- io.netty:netty-codec-http:4.1.68.Final
+- io.netty:netty-codec-http2:4.1.68.Final
+- io.netty:netty-codec:4.1.68.Final
+- io.netty:netty-transport:4.1.68.Final
+- io.netty:netty-resolver:4.1.68.Final
+- io.netty:netty-common:4.1.68.Final
+- io.netty:netty-buffer:4.1.68.Final
+- io.netty:netty-handler:4.1.68.Final
+- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.68.Final
+- io.netty:netty-transport-native-unix-common:4.1.68.Final
+- com.typesafe.netty:netty-reactive-streams-http:2.0.5
+- com.typesafe.netty:netty-reactive-streams:2.0.5
+- org.apache.httpcomponents:httpclient:4.5.13
+- org.apache.httpcomponents:httpcore:4.4.14
+
+
+This project bundles the following dependencies under the Creative Commons Zero license (https://creativecommons.org/publicdomain/zero/1.0/).
Review comment:
Latest Shade output:
```
[INFO] --- maven-shade-plugin:3.1.1:shade (shade-flink) @ flink-sql-connector-aws-kinesis-data-streams ---
[INFO] Including org.apache.flink:flink-connector-aws-kinesis-data-streams:jar:1.15-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-base:jar:1.15-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-aws-base:jar:1.15-SNAPSHOT in the shaded jar.
[INFO] Including software.amazon.awssdk:sdk-core:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:annotations:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:http-client-spi:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:metrics-spi:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:utils:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:profiles:jar:2.17.52 in the shaded jar.
[INFO] Including org.reactivestreams:reactive-streams:jar:1.0.3 in the shaded jar.
[INFO] Including software.amazon.awssdk:kinesis:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-cbor-protocol:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:third-party-jackson-dataformat-cbor:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:third-party-jackson-core:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-json-protocol:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:json-utils:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:protocol-core:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:auth:jar:2.17.52 in the shaded jar.
[INFO] Excluding software.amazon.eventstream:eventstream:jar:1.0.1 from the shaded jar.
[INFO] Including software.amazon.awssdk:regions:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-core:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:apache-client:jar:2.17.52 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.13 in the shaded jar.
[INFO] Excluding commons-logging:commons-logging:jar:1.1.3 from the shaded jar.
[INFO] Excluding commons-codec:commons-codec:jar:1.15 from the shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.14 in the shaded jar.
[INFO] Including software.amazon.awssdk:netty-nio-client:jar:2.17.52 in the shaded jar.
[INFO] Including io.netty:netty-codec-http:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-codec-http2:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-codec:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-transport:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-resolver:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-common:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-buffer:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-handler:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-unix-common:jar:4.1.68.Final in the shaded jar.
[INFO] Including com.typesafe.netty:netty-reactive-streams-http:jar:2.0.5 in the shaded jar.
[INFO] Including com.typesafe.netty:netty-reactive-streams:jar:2.0.5 in the shaded jar.
[INFO] Including software.amazon.awssdk:sts:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-query-protocol:jar:2.17.52 in the shaded jar.
[INFO] Including org.apache.flink:flink-table-common:jar:1.15-SNAPSHOT in the shaded jar.
[INFO] Excluding org.apache.flink:flink-core:jar:1.15-SNAPSHOT from the shaded jar.
[INFO] Excluding org.apache.flink:flink-annotations:jar:1.15-SNAPSHOT from the shaded jar.
[INFO] Excluding org.apache.flink:flink-metrics-core:jar:1.15-SNAPSHOT from the shaded jar.
[INFO] Excluding org.apache.commons:commons-lang3:jar:3.3.2 from the shaded jar.
[INFO] Excluding com.esotericsoftware.kryo:kryo:jar:2.24.0 from the shaded jar.
[INFO] Excluding com.esotericsoftware.minlog:minlog:jar:1.2 from the shaded jar.
[INFO] Excluding commons-collections:commons-collections:jar:3.2.2 from the shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-guava:jar:30.1.1-jre-14.0 from the shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-asm-7:jar:7.1-14.0 from the shaded jar.
[INFO] Excluding com.ibm.icu:icu4j:jar:67.1 from the shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-force-shading:jar:14.0 from the shaded jar.
[INFO] Excluding org.objenesis:objenesis:jar:2.1 from the shaded jar.
[INFO] Excluding org.apache.commons:commons-compress:jar:1.21 from the shaded jar.
[INFO] No artifact matching filter io.netty:netty
[INFO] Replacing original artifact with shaded artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4c5b4e65b42382c17bd98884f18e441e5a881e83 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028)
* 6ac66f07be10e8c320e77b89e41fc6ba17b1571e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
}, {
"hash" : "448450417bf411ac2b7de95792c4297cc42250a9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30147",
"triggerID" : "448450417bf411ac2b7de95792c4297cc42250a9",
"triggerType" : "PUSH"
}, {
"hash" : "c9ca1ae40dd0845541df78dc73eb6cad2a227ad6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30171",
"triggerID" : "c9ca1ae40dd0845541df78dc73eb6cad2a227ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448450417bf411ac2b7de95792c4297cc42250a9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30147)
* c9ca1ae40dd0845541df78dc73eb6cad2a227ad6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30171)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4c5b4e65b42382c17bd98884f18e441e5a881e83 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019968379
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4c5b4e65b42382c17bd98884f18e441e5a881e83 (Mon Jan 24 10:55:15 UTC 2022)
**Warnings:**
* **4 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1021312806
Sorry for sounding a bit harsh but please open separate tickets for the different concerns. This is already the third PR belonging to https://issues.apache.org/jira/browse/FLINK-24905. It makes it hard to keep track of the progress and relate the work to a ticket. You can also create sub tickets for a story that is probably most suitable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
}, {
"hash" : "448450417bf411ac2b7de95792c4297cc42250a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30147",
"triggerID" : "448450417bf411ac2b7de95792c4297cc42250a9",
"triggerType" : "PUSH"
}, {
"hash" : "c9ca1ae40dd0845541df78dc73eb6cad2a227ad6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30171",
"triggerID" : "c9ca1ae40dd0845541df78dc73eb6cad2a227ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9ca1ae40dd0845541df78dc73eb6cad2a227ad6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30171)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
}, {
"hash" : "448450417bf411ac2b7de95792c4297cc42250a9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448450417bf411ac2b7de95792c4297cc42250a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ac66f07be10e8c320e77b89e41fc6ba17b1571e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069)
* 448450417bf411ac2b7de95792c4297cc42250a9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer closed pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
dannycranmer closed pull request #18468:
URL: https://github.com/apache/flink/pull/18468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4c5b4e65b42382c17bd98884f18e441e5a881e83 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4c5b4e65b42382c17bd98884f18e441e5a881e83 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028)
* 6ac66f07be10e8c320e77b89e41fc6ba17b1571e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1021312806
Sorry for sounding a bit harsh but please open separate tickets for the different concerns. This is already the third PR belonging to https://issues.apache.org/jira/browse/FLINK-24905. It makes it hard to keep track of the progress and relate the work to a ticket. You can also create sub tickets for a story that is probably most suitable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18468:
URL: https://github.com/apache/flink/pull/18468#discussion_r790788442
##########
File path: flink-connectors/flink-sql-connector-aws-kinesis-data-streams/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,47 @@
+flink-sql-connector-aws-kinesis-data-streams
+
+Copyright 2014-2021 The Apache Software Foundation
Review comment:
Should this be 2022 now?
##########
File path: flink-connectors/flink-sql-connector-aws-kinesis-data-streams/pom.xml
##########
@@ -0,0 +1,113 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-aws-kinesis-data-streams</artifactId>
+ <name>Flink : Connectors : SQL : AWS Kinesis Data Streams</name>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-aws-kinesis-data-streams</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
Looking at your shading:
```
**[INFO] --- maven-shade-plugin:3.2.4:shade (shade-flink) @ flink-sql-connector-aws-kinesis-data-streams ---
[INFO] Including org.apache.flink:flink-connector-aws-kinesis-data-streams:jar:1.15-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-base:jar:1.15-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-aws-base:jar:1.15-SNAPSHOT in the shaded jar.
[INFO] Including software.amazon.awssdk:sdk-core:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:annotations:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:http-client-spi:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:metrics-spi:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:utils:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:profiles:jar:2.17.52 in the shaded jar.
[INFO] Including org.reactivestreams:reactive-streams:jar:1.0.3 in the shaded jar.
[INFO] Including software.amazon.awssdk:kinesis:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-cbor-protocol:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:third-party-jackson-dataformat-cbor:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:third-party-jackson-core:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-json-protocol:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:json-utils:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:protocol-core:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:auth:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:regions:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-core:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:apache-client:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:netty-nio-client:jar:2.17.52 in the shaded jar.
[INFO] Including io.netty:netty-codec-http:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-codec-http2:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-codec:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-transport:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-resolver:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-common:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-buffer:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-handler:jar:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.68.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-unix-common:jar:4.1.68.Final in the shaded jar.
[INFO] Including com.typesafe.netty:netty-reactive-streams-http:jar:2.0.5 in the shaded jar.
[INFO] Including com.typesafe.netty:netty-reactive-streams:jar:2.0.5 in the shaded jar.
[INFO] Including software.amazon.awssdk:sts:jar:2.17.52 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-query-protocol:jar:2.17.52 in the shaded jar.
[INFO] Including org.apache.flink:flink-table-common:jar:1.15-SNAPSHOT in the shaded jar.
[INFO] Excluding software.amazon.eventstream:eventstream:jar:1.0.1 from the shaded jar.
[INFO] Excluding org.apache.httpcomponents:httpclient:jar:4.5.13 from the shaded jar.
[INFO] Excluding commons-logging:commons-logging:jar:1.1.3 from the shaded jar.
[INFO] Excluding commons-codec:commons-codec:jar:1.15 from the shaded jar.
[INFO] Excluding org.apache.httpcomponents:httpcore:jar:4.4.14 from the shaded jar.
[INFO] Excluding org.apache.flink:flink-core:jar:1.15-SNAPSHOT from the shaded jar.
[INFO] Excluding org.apache.flink:flink-annotations:jar:1.15-SNAPSHOT from the shaded jar.
[INFO] Excluding org.apache.flink:flink-metrics-core:jar:1.15-SNAPSHOT from the shaded jar.
[INFO] Excluding org.apache.commons:commons-lang3:jar:3.3.2 from the shaded jar.
[INFO] Excluding com.esotericsoftware.kryo:kryo:jar:2.24.0 from the shaded jar.
[INFO] Excluding com.esotericsoftware.minlog:minlog:jar:1.2 from the shaded jar.
[INFO] Excluding commons-collections:commons-collections:jar:3.2.2 from the shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-guava:jar:30.1.1-jre-14.0 from the shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-asm-7:jar:7.1-14.0 from the shaded jar.
[INFO] Excluding com.ibm.icu:icu4j:jar:67.1 from the shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-force-shading:jar:14.0 from the shaded jar.
[INFO] Excluding org.objenesis:objenesis:jar:2.1 from the shaded jar.
[INFO] Excluding org.apache.commons:commons-compress:jar:1.21 from the shaded jar.
[INFO] No artifact matching filter io.netty:netty
```
Is this expected?
```
[INFO] Excluding org.apache.httpcomponents:httpclient:jar:4.5.13 from the shaded jar.
```
FYI we shade for legacy connector, it might be required for ASSUME_ROLE:
```
[INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.13 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.14 in the shaded jar.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ac66f07be10e8c320e77b89e41fc6ba17b1571e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
}, {
"hash" : "448450417bf411ac2b7de95792c4297cc42250a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30147",
"triggerID" : "448450417bf411ac2b7de95792c4297cc42250a9",
"triggerType" : "PUSH"
}, {
"hash" : "c9ca1ae40dd0845541df78dc73eb6cad2a227ad6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30171",
"triggerID" : "c9ca1ae40dd0845541df78dc73eb6cad2a227ad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ac66f07be10e8c320e77b89e41fc6ba17b1571e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069)
* 448450417bf411ac2b7de95792c4297cc42250a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30147)
* c9ca1ae40dd0845541df78dc73eb6cad2a227ad6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30171)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1020155387
@vahmed-hamdy There are no documentation updates. Is this coming in a different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18468:
URL: https://github.com/apache/flink/pull/18468#discussion_r792625988
##########
File path: flink-connectors/flink-sql-connector-aws-kinesis-data-streams/pom.xml
##########
@@ -0,0 +1,113 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>flink-connectors</artifactId>
+ <groupId>org.apache.flink</groupId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-connector-aws-kinesis-data-streams</artifactId>
+ <name>Flink : Connectors : SQL : AWS Kinesis Data Streams</name>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-aws-kinesis-data-streams</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
Sorry I had not pushed this comment from the other day, might be outdated now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #18468: [FLINK-25810][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #18468:
URL: https://github.com/apache/flink/pull/18468#discussion_r793351578
##########
File path: flink-connectors/flink-sql-connector-aws-kinesis-data-streams/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,49 @@
+flink-sql-connector-aws-kinesis-data-streams
+
+Copyright 2014-2021 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- software.amazon.awssdk:kinesis:2.17.52
+- software.amazon.awssdk:aws-cbor-protocol:2.17.52
+- software.amazon.awssdk:aws-json-protocol:2.17.52
+- software.amazon.awssdk:protocol-core:2.17.52
+- software.amazon.awssdk:profiles:2.17.52
+- software.amazon.awssdk:sdk-core:2.17.52
+- software.amazon.awssdk:auth:2.17.52
+- software.amazon.eventstream:eventstream:1.0.1
+- software.amazon.awssdk:http-client-spi:2.17.52
+- software.amazon.awssdk:regions:2.17.52
+- software.amazon.awssdk:annotations:2.17.52
+- software.amazon.awssdk:utils:2.17.52
+- software.amazon.awssdk:aws-core:2.17.52
+- software.amazon.awssdk:metrics-spi:2.17.52
+- software.amazon.awssdk:apache-client:2.17.52
+- software.amazon.awssdk:netty-nio-client:2.17.52
+- software.amazon.awssdk:sts:2.17.52
+- software.amazon.awssdk:aws-query-protocol:2.17.52
+- software.amazon.awssdk:json-utils:2.17.52
+- software.amazon.awssdk:third-party-jackson-core:2.17.52
+- software.amazon.awssdk:third-party-jackson-dataformat-cbor:2.17.52
+- io.netty:netty-codec-http:4.1.68.Final
+- io.netty:netty-codec-http2:4.1.68.Final
+- io.netty:netty-codec:4.1.68.Final
+- io.netty:netty-transport:4.1.68.Final
+- io.netty:netty-resolver:4.1.68.Final
+- io.netty:netty-common:4.1.68.Final
+- io.netty:netty-buffer:4.1.68.Final
+- io.netty:netty-handler:4.1.68.Final
+- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.68.Final
+- io.netty:netty-transport-native-unix-common:4.1.68.Final
+- com.typesafe.netty:netty-reactive-streams-http:2.0.5
+- com.typesafe.netty:netty-reactive-streams:2.0.5
+- org.apache.httpcomponents:httpclient:4.5.13
+- org.apache.httpcomponents:httpcore:4.4.14
+
+
+This project bundles the following dependencies under the Creative Commons Zero license (https://creativecommons.org/publicdomain/zero/1.0/).
Review comment:
I verified this list matches the NOTICE file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4c5b4e65b42382c17bd98884f18e441e5a881e83 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028)
* 6ac66f07be10e8c320e77b89e41fc6ba17b1571e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18468:
URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30028",
"triggerID" : "4c5b4e65b42382c17bd98884f18e441e5a881e83",
"triggerType" : "PUSH"
}, {
"hash" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069",
"triggerID" : "6ac66f07be10e8c320e77b89e41fc6ba17b1571e",
"triggerType" : "PUSH"
}, {
"hash" : "448450417bf411ac2b7de95792c4297cc42250a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30147",
"triggerID" : "448450417bf411ac2b7de95792c4297cc42250a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ac66f07be10e8c320e77b89e41fc6ba17b1571e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30069)
* 448450417bf411ac2b7de95792c4297cc42250a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30147)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org