[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

["Gil Portenseigne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587380#comment-16587380 ] 

Gil Portenseigne commented on OFBIZ-7598:
-----------------------------------------

Hello [~suraj.khurana], i will try to explain how i think this improvement should be rewritten looking at your patch.

First I think that using hideHeader property for this purpose is wrong. hideHeader is the property of a list form/grid that indicate to not render table header row (in case that the data are simple enough to be understood like in findparty screen). It must only do that.

To render a display message when no data is retrieved is not dependent on form definition and though should not appear in modelForm as such, but only in formRenderer. Indeed ModelForm purpose is to modelize xml form through java immutable objects, allowing thread safety. If the state of something in the modelForm could be changed, that'll break thread safe.

FormRenderer should suffice to implement this improvement, let me know if you need assistance on this matter.

 

 

> Empty header row should not render if list to render in file is empty
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-7598
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7598
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png
>
>
> If list inside form doesn't contain data, then header row should not render from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)