You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/24 02:49:29 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #6162: UI - Fixes UI bugs
utchoang opened a new pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162
### Description
This PR fixes https://github.com/apache/cloudstack/issues/6107
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1080420458
@utchoang When in a project view, and the user clicks on a specific ssh key, it should go into the detail view of that key. However it results in a 404. Caused by using `name=<key-id>` instead of `name=<key-name>` in the request when the record has annotations
https://github.com/apache/cloudstack/blob/main/ui/src/components/view/ListView.vue#L102
should have the same check for ssh as
https://github.com/apache/cloudstack/blob/main/ui/src/components/view/ListView.vue#L113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1081417902
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1082543846
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6162 (SL-JID-1314)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1077818394
Thanks for the PR @utchoang - 2 new issues have been added since you have open the PR, if its not too much to ask can you please consider them as well on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1082529806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1080253357
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6162 (SL-JID-1305)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1080249145
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1080949828
Yes @utchoang as @davidjumani describes, the issue comes when clicking on any created SSH key on the list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1081417385
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1081825293
Thanks for the fixes @utchoang, verified the reported ones are fixed. Strangely the SSH keys now work when clicking on them from SSH keys list but if I create a comment for it and try to navigate to a SSH key from the comments section then I still get the 404 error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1080254686
@nvazquez `Clicking on a SSH key gives 404 error` does it have to click SSH key pair from the menu? I tried to do it, no problem at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1080420458
@utchoang When the user clicks on a specific ssh key, it should go into the detail view of that key. However it results in a 404. Caused by using `name=<key-id>` instead of `name=<key-name>` in the request when the record has annotations
https://github.com/apache/cloudstack/blob/main/ui/src/components/view/ListView.vue#L102
should have the same check for ssh as
https://github.com/apache/cloudstack/blob/main/ui/src/components/view/ListView.vue#L113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1082529881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1082540461
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1080249578
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1078903579
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1081825293
Thanks for the fixes @utchoang, verified the reported ones are fixed. Strangely the SSH keys now works when clicking on them from SSH keys list but if I create a comment for it and try to navigate to a SSH key from the comments section then I still get the 404 error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1079082393
Thanks @utchoang I have validated the following:
- As user: Does not refresh dashboard values when switching from a project to the default view -> FIXED
- Launch VM and stay on page does not work -> FIXED
- Destroy instance expanded menu throws errors in the console -> FIXED
- Clear notification button remains when a notification is dismissed via the 'x' icon -> FIXED
Have found some additional issues while testing the PR:
- As a user, accepting a project invitation worked but after accepting it the page continued loading and the popup didn't close - had to refresh the page to continue
<img width="851" alt="Screen Shot 2022-03-25 at 11 12 13" src="https://user-images.githubusercontent.com/5295080/160139534-882f9500-cf7f-4dc5-9208-11d92f2f4b0a.png">
- As a user, the events view below the dashboard is not aligned (it works when switching to a project)
<img width="858" alt="Screen Shot 2022-03-25 at 11 15 12" src="https://user-images.githubusercontent.com/5295080/160139808-e62ba0ee-d899-4e56-817c-55ec92468b53.png">
- On a project view, the Kubernetes and Kubernetes ISO icons are not visible:
<img width="276" alt="Screen Shot 2022-03-25 at 11 28 05" src="https://user-images.githubusercontent.com/5295080/160140192-a0a680f0-8801-468b-988b-308fbdbaef79.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1082540300
lòng gà xào hành
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1080420458
@utchoang When in a project view, and the user clicks on a specific ssh key, it should go into the detail view of that key. However it results in a 404. Caused by using `name=<key-id>` instead of `name=<key-name>` in the request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1082540764
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1081420644
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6162 (SL-JID-1311)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1077818394
Thanks for the PR @utchoang - 2 new issues have been added since you have open the PR, if its not too much to ask can you please consider them as well on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on pull request #6162: UI - Fixes UI bugs
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on pull request #6162:
URL: https://github.com/apache/cloudstack/pull/6162#issuecomment-1079082393
Thanks @utchoang I have validated the following:
- As user: Does not refresh dashboard values when switching from a project to the default view -> FIXED
- Launch VM and stay on page does not work -> FIXED
- Destroy instance expanded menu throws errors in the console -> FIXED
- Clear notification button remains when a notification is dismissed via the 'x' icon -> FIXED
Have found some additional issues while testing the PR:
- As a user, accepting a project invitation worked but after accepting it the page continued loading and the popup didn't close - had to refresh the page to continue
<img width="851" alt="Screen Shot 2022-03-25 at 11 12 13" src="https://user-images.githubusercontent.com/5295080/160139534-882f9500-cf7f-4dc5-9208-11d92f2f4b0a.png">
- As a user, the events view below the dashboard is not aligned (it works when switching to a project)
<img width="858" alt="Screen Shot 2022-03-25 at 11 15 12" src="https://user-images.githubusercontent.com/5295080/160139808-e62ba0ee-d899-4e56-817c-55ec92468b53.png">
- On a project view, the Kubernetes and Kubernetes ISO icons are not visible:
<img width="276" alt="Screen Shot 2022-03-25 at 11 28 05" src="https://user-images.githubusercontent.com/5295080/160140192-a0a680f0-8801-468b-988b-308fbdbaef79.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org