[GitHub] [beam] Amar3tto commented on a diff in pull request #22584: [CdapIO] Integration CdapIO with SparkReceiverIO

[GitBox <gi...@apache.org>]

Amar3tto commented on code in PR #22584:
URL: https://github.com/apache/beam/pull/22584#discussion_r979892010


##########
sdks/java/io/cdap/build.gradle:
##########
@@ -52,14 +52,17 @@ dependencies {
     implementation library.java.cdap_plugin_zendesk
     implementation library.java.commons_lang3
     implementation library.java.guava
+    implementation library.java.google_code_gson
     implementation library.java.hadoop_common
     implementation library.java.hadoop_mapreduce_client_core
     implementation library.java.jackson_core
     implementation library.java.jackson_databind
     implementation library.java.slf4j_api
+    implementation library.java.spark_streaming

Review Comment:
   Yes, it would be good to clarify that.
   We don't use Spark environment in CdapIO. Our goal is only to mimic all Spark classes related to Cdap Plugins in order to use the business logic.
   At the moment, all the Cdap plugins we want to support use Spark 2, so we use Spark 2 here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org