[GitHub] [ignite-3] lowka commented on a diff in pull request #2602: IGNITE-20019 Sql. Implement system views manager

["lowka (via GitHub)" <gi...@apache.org>]

lowka commented on code in PR #2602:
URL: https://github.com/apache/ignite-3/pull/2602#discussion_r1333085802


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManager.java:
##########
@@ -44,7 +44,7 @@ public interface CatalogManager extends IgniteComponent, CatalogService {
      * @param commands Commands to execute.
      * @return Future representing result of execution.
      */
-    CompletableFuture<Void> execute(List<CatalogCommand> commands);
+    CompletableFuture<Void> execute(Collection<CatalogCommand> commands);

Review Comment:
   It is better not to change this signature, because the order of commands matters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org