You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/19 14:20:42 UTC
[GitHub] [skywalking-java] dashanji opened a new pull request #28: fix agent.config
dashanji opened a new pull request #28:
URL: https://github.com/apache/skywalking-java/pull/28
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
Follow the doc to readjust the order of agent.config and fix the mismatched naming between the doc and the agent.config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] kezhenxu94 commented on a change in pull request #28: fix agent.config
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #28:
URL: https://github.com/apache/skywalking-java/pull/28#discussion_r711752641
##########
File path: apm-sniffer/config/agent.config
##########
@@ -219,7 +222,7 @@ plugin.dubbo.consumer_arguments_length_threshold=${SW_PLUGIN_DUBBO_CONSUMER_ARGU
# Apache Dubbo provider collect `arguments` in RPC call, use `Object#toString` to collect `arguments`.
plugin.dubbo.collect_provider_arguments=${SW_PLUGIN_DUBBO_COLLECT_PROVIDER_ARGUMENTS:false}
# When `plugin.dubbo.provider_consumer_arguments` is `true`, Arguments of length from the front will to the OAP backend
-plugin.dubbo.consumer_provider_length_threshold=${SW_PLUGIN_DUBBO_CONSUMER_PROVIDER_LENGTH_THRESHOLD:256}
Review comment:
Also update the typo in line 221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #28: fix agent.config
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #28:
URL: https://github.com/apache/skywalking-java/pull/28#discussion_r711830090
##########
File path: apm-sniffer/config/agent.config
##########
@@ -20,17 +20,16 @@ agent.namespace=${SW_AGENT_NAMESPACE:}
# The service name in UI
agent.service_name=${SW_AGENT_NAME:Your_ApplicationName}
-# Instance name is the identity of an instance, should be unique in the service. If empty, SkyWalking agent will
-# generate an 32-bit uuid. BY Default, SkyWalking uses UUID@hostname as the instance name. Max length is 50(UTF-8 char)
-agent.instance_name=${SW_AGENT_INSTANCE_NAME:}
-
Review comment:
Why is this removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #28: fix agent.config
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #28:
URL: https://github.com/apache/skywalking-java/pull/28#discussion_r711830856
##########
File path: docs/menu.yml
##########
@@ -28,14 +28,14 @@ catalog:
catalog:
- name: "Supported middleware, framework and library"
path: "/en/setup/service-agent/java-agent/Supported-list"
- - name: "Dynamic Configurations"
- path: "/en/setup/service-agent/java-agent/configurations#dynamic-configurations"
- name: "Optional Plugins"
path: "/en/setup/service-agent/java-agent/readme#optional-plugins"
- name: "Bootstrap/JVM class plugin"
path: "/en/setup/service-agent/java-agent/readme#bootstrap-class-plugins"
- name: "Agent Configuration Properties"
path: "/en/setup/service-agent/java-agent/configurations#table-of-agent-configuration-properties"
+ - name: "Dynamic Configurations"
+ path: "/en/setup/service-agent/java-agent/configurations#dynamic-configurations"
Review comment:
I did this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] dashanji commented on a change in pull request #28: fix agent.config
Posted by GitBox <gi...@apache.org>.
dashanji commented on a change in pull request #28:
URL: https://github.com/apache/skywalking-java/pull/28#discussion_r711752783
##########
File path: apm-sniffer/config/agent.config
##########
@@ -219,7 +222,7 @@ plugin.dubbo.consumer_arguments_length_threshold=${SW_PLUGIN_DUBBO_CONSUMER_ARGU
# Apache Dubbo provider collect `arguments` in RPC call, use `Object#toString` to collect `arguments`.
plugin.dubbo.collect_provider_arguments=${SW_PLUGIN_DUBBO_COLLECT_PROVIDER_ARGUMENTS:false}
# When `plugin.dubbo.provider_consumer_arguments` is `true`, Arguments of length from the front will to the OAP backend
-plugin.dubbo.consumer_provider_length_threshold=${SW_PLUGIN_DUBBO_CONSUMER_PROVIDER_LENGTH_THRESHOLD:256}
Review comment:
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #28: fix agent.config
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #28:
URL: https://github.com/apache/skywalking-java/pull/28#issuecomment-922488354
FYI @kezhenxu94 When you have time, let's add some skip mechanism back to this new repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #28: fix agent.config
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #28:
URL: https://github.com/apache/skywalking-java/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org