You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/03/07 00:11:57 UTC
Re: Review Request 69582: Added a test to verify a bug fix for the
master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69582/
-----------------------------------------------------------
(Updated March 7, 2019, 12:11 a.m.)
Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and Meng Zhu.
Bugs: MESOS-9460
https://issues.apache.org/jira/browse/MESOS-9460
Repository: mesos
Description
-------
Added a test to verify a bug fix for the master.
Diffs (updated)
-----
src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
Diff: https://reviews.apache.org/r/69582/diff/2/
Changes: https://reviews.apache.org/r/69582/diff/1-2/
Testing
-------
Ran this test before and after the preceding fix. Before the fix, the test fails reliably. After the fix, the test passes reliably.
Thanks,
Greg Mann
Re: Review Request 69582: Added a test to verify a bug fix for the
master.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69582/#review213715
-----------------------------------------------------------
PASS: Mesos patch 69582 was successfully built and tested.
Reviews applied: `['70147', '69582']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2962/mesos-review-69582
- Mesos Reviewbot Windows
On March 6, 2019, 4:11 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69582/
> -----------------------------------------------------------
>
> (Updated March 6, 2019, 4:11 p.m.)
>
>
> Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and Meng Zhu.
>
>
> Bugs: MESOS-9460
> https://issues.apache.org/jira/browse/MESOS-9460
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to verify a bug fix for the master.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
>
>
> Diff: https://reviews.apache.org/r/69582/diff/2/
>
>
> Testing
> -------
>
> Ran this test before and after the preceding fix. Before the fix, the test fails reliably. After the fix, the test passes reliably.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69582: Added a test to verify a bug fix for the
master.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69582/#review213511
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70147, 69582]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 7, 2019, 12:11 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69582/
> -----------------------------------------------------------
>
> (Updated March 7, 2019, 12:11 a.m.)
>
>
> Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and Meng Zhu.
>
>
> Bugs: MESOS-9460
> https://issues.apache.org/jira/browse/MESOS-9460
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to verify a bug fix for the master.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
>
>
> Diff: https://reviews.apache.org/r/69582/diff/2/
>
>
> Testing
> -------
>
> Ran this test before and after the preceding fix. Before the fix, the test fails reliably. After the fix, the test passes reliably.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69582: Added a test to verify a bug fix for the
master.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69582/#review213705
-----------------------------------------------------------
PASS: Mesos patch 69582 was successfully built and tested.
Reviews applied: `['70147', '69582']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2951/mesos-review-69582
- Mesos Reviewbot Windows
On March 7, 2019, 12:11 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69582/
> -----------------------------------------------------------
>
> (Updated March 7, 2019, 12:11 a.m.)
>
>
> Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and Meng Zhu.
>
>
> Bugs: MESOS-9460
> https://issues.apache.org/jira/browse/MESOS-9460
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to verify a bug fix for the master.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
>
>
> Diff: https://reviews.apache.org/r/69582/diff/2/
>
>
> Testing
> -------
>
> Ran this test before and after the preceding fix. Before the fix, the test fails reliably. After the fix, the test passes reliably.
>
>
> Thanks,
>
> Greg Mann
>
>