You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2014/04/01 17:33:56 UTC

libsvn_ra_git [was: svn commit: r1583639 [1/3] - ...]

Stefan Sperling wrote:

>>  URL: http://svn.apache.org/r1583639
>>  Log:
>>  Create the ra-git branch: git repository access for Suversion
> 
> For those who are going to test/review this:
> 
> I forgot to mention that we currently use libgit-0.20.0 as our base.
> A different version of libgit2 might not work as expected.
> 
> Building libgit2 is a breeze, by the way. It has a very portable
> cmake-based build system and no externals dependencies (except
> libssh, but that isn't yet supported by ra-git anyway).

Very cool!

I committed a couple of tweaks to the 'build.conf' file to help it build on Linux (I'm using Ubuntu 12.04). For the record, I built and installed libgit2 like this:

[[[
$ cd ~/src/libgit2-0.20.0
$ mkdir build && cd build
$ cmake .. -DCMAKE_INSTALL_PREFIX=~/.local/libgit2-0.20.0
[...]
$ cmake --build . --target install
[...]
[ 23%] Built target git2
[...]
[100%] Built target libgit2_clar
Install the project...
-- Install configuration: "Debug"
-- Installing: /home/julianfoad/.local/libgit2-0.20.0/lib/libgit2.so.0.20.0
-- Installing: /home/julianfoad/.local/libgit2-0.20.0/lib/libgit2.so.0
-- Installing: /home/julianfoad/.local/libgit2-0.20.0/lib/libgit2.so
-- Installing: /home/julianfoad/.local/libgit2-0.20.0/lib/pkgconfig/libgit2.pc
[...]
-- Installing: /home/julianfoad/.local/libgit2-0.20.0/include/git2/diff.h
-- Installing: /home/julianfoad/.local/libgit2-0.20.0/include/git2.h
]]]

And then I configured Subversion with:

  LDFLAGS=-Wl,-rpath,$HOME/.local/libgit2-0.20.0/lib [my normal ./configure ... command]  --with-libgit2=$HOME/.local/libgit2-0.20.0

- Julian

Re: libsvn_ra_git [was: svn commit: r1583639 [1/3] - ...]

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Apr 01, 2014 at 11:49:04AM -0400, Mark Phippard wrote:
> Did you guys run this by legal@?
> 
> libgit2 is GPLv2 licensed.  I know they claim to support permissive linking
> and that should be the end of it, but ASF legal might still want to weigh
> in.

I don't see a problem. libgit2 is intended to be an optional dependency.
People who don't like the GPL or don't trust the linking exception
promise can keep using Subversion's native repository backends.

It's not like github would ever turn around on their linking exception
promise, would they? I really doubt that.

Also, I think we should keep the discussion focused on technical matters.

Re: libsvn_ra_git [was: svn commit: r1583639 [1/3] - ...]

Posted by Mark Phippard <ma...@gmail.com>.
On Tue, Apr 1, 2014 at 11:33 AM, Julian Foad <ju...@btopenworld.com>wrote:

> Stefan Sperling wrote:
>
> >>  URL: http://svn.apache.org/r1583639
> >>  Log:
> >>  Create the ra-git branch: git repository access for Suversion
> >
> > For those who are going to test/review this:
> >
> > I forgot to mention that we currently use libgit-0.20.0 as our base.
> > A different version of libgit2 might not work as expected.
> >
> > Building libgit2 is a breeze, by the way. It has a very portable
> > cmake-based build system and no externals dependencies (except
> > libssh, but that isn't yet supported by ra-git anyway).
>
> Very cool!
>
> I committed a couple of tweaks to the 'build.conf' file to help it build
> on Linux (I'm using Ubuntu 12.04). For the record, I built and installed
> libgit2 like this:
>
>
Did you guys run this by legal@?

libgit2 is GPLv2 licensed.  I know they claim to support permissive linking
and that should be the end of it, but ASF legal might still want to weigh
in.


-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/