You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/31 08:30:45 UTC

[GitHub] [dubbo-samples] AlbumenJ opened a new pull request #202: Add dubbo-samples-spi-compatible module IT support

AlbumenJ opened a new pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-samples] kylixs commented on a change in pull request #202: Add dubbo-samples-spi-compatible module IT support

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202#discussion_r550434207



##########
File path: dubbo-samples-spi-compatible/case-configuration.yml
##########
@@ -14,11 +14,33 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from: app-builtin-zookeeper.yml
-
 props:
   project_name: dubbo-samples-spi-compatible
   main_class: org.apache.dubbo.samples.basic.SpiCompatibleProvider
   zookeeper_port: 2181
-  dubbo_port: 20880
 
+services:
+  ${project_name}:

Review comment:
       容器之间访问不需要暴露端口吧？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-samples] kylixs commented on a change in pull request #202: Add dubbo-samples-spi-compatible module IT support

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202#discussion_r550428722



##########
File path: dubbo-samples-spi-compatible/case-configuration.yml
##########
@@ -14,11 +14,33 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from: app-builtin-zookeeper.yml
-
 props:
   project_name: dubbo-samples-spi-compatible
   main_class: org.apache.dubbo.samples.basic.SpiCompatibleProvider
   zookeeper_port: 2181
-  dubbo_port: 20880
 
+services:
+  ${project_name}:

Review comment:
       可以直接使用模板 `app-builtin-zookeeper.yml`，已经添加了zk的`systemProps `




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-samples] chickenlj merged pull request #202: Add dubbo-samples-spi-compatible module IT support

Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-samples] AlbumenJ commented on a change in pull request #202: Add dubbo-samples-spi-compatible module IT support

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202#discussion_r550430231



##########
File path: dubbo-samples-spi-compatible/case-configuration.yml
##########
@@ -14,11 +14,33 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from: app-builtin-zookeeper.yml
-
 props:
   project_name: dubbo-samples-spi-compatible
   main_class: org.apache.dubbo.samples.basic.SpiCompatibleProvider
   zookeeper_port: 2181
-  dubbo_port: 20880
 
+services:
+  ${project_name}:

Review comment:
       目的是为了解决dubbo端口检测机制，`dubbo-samples-spi-compatible` 实际上并没有对外暴露端口




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-samples] AlbumenJ commented on pull request #202: Add dubbo-samples-spi-compatible module IT support

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202#issuecomment-752888150


   ![image](https://user-images.githubusercontent.com/9292748/103401862-9fe12c80-4b85-11eb-85e3-474a709e90f2.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-samples] kylixs commented on a change in pull request #202: Add dubbo-samples-spi-compatible module IT support

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202#discussion_r550438740



##########
File path: dubbo-samples-spi-compatible/case-configuration.yml
##########
@@ -14,11 +14,33 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from: app-builtin-zookeeper.yml
-
 props:
   project_name: dubbo-samples-spi-compatible
   main_class: org.apache.dubbo.samples.basic.SpiCompatibleProvider
   zookeeper_port: 2181
-  dubbo_port: 20880
 
+services:
+  ${project_name}:

Review comment:
       请在case-configuration.yml  test的 waitPortsBeforeRun 下面加一个英文注释说明一下




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-samples] kylixs commented on a change in pull request #202: Add dubbo-samples-spi-compatible module IT support

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202#discussion_r550434429



##########
File path: dubbo-samples-spi-compatible/case-configuration.yml
##########
@@ -14,11 +14,33 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from: app-builtin-zookeeper.yml
-
 props:
   project_name: dubbo-samples-spi-compatible
   main_class: org.apache.dubbo.samples.basic.SpiCompatibleProvider
   zookeeper_port: 2181
-  dubbo_port: 20880
 
+services:
+  ${project_name}:

Review comment:
       > 目的是为了解决dubbo端口检测机制
   
   可以具体一些吗？ checkPortsAfterRun/checkLog其实是不需要的




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-samples] AlbumenJ commented on a change in pull request #202: Add dubbo-samples-spi-compatible module IT support

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-samples/pull/202#discussion_r550435241



##########
File path: dubbo-samples-spi-compatible/case-configuration.yml
##########
@@ -14,11 +14,33 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from: app-builtin-zookeeper.yml
-
 props:
   project_name: dubbo-samples-spi-compatible
   main_class: org.apache.dubbo.samples.basic.SpiCompatibleProvider
   zookeeper_port: 2181
-  dubbo_port: 20880
 
+services:
+  ${project_name}:

Review comment:
        builtin 配置文件中有以下内容：
   ```
     ${project_name}-test:
       type: test
       basedir: .
       tests:
         - "**/*IT.class"
       systemProps:
         - zookeeper.address=${project_name}
         - zookeeper.port=${zookeeper_port}
         - dubbo.address=${project_name}
         - dubbo.port=${dubbo_port}
       waitPortsBeforeRun:
         - ${project_name}:${zookeeper_port}
         - ${project_name}:${dubbo_port}
       depends_on:
         - ${project_name}
   ```
   其中 `- ${project_name}:${dubbo_port}` 用于检测服务提供者的 dubbo 端口是否已经启动，但由于 `dubbo-samples-spi-compatible` 自己实现了一个服务，导致其实际上不会对外暴露端口，也即是消费者侧是不可能通过 telnet 该端口来判断服务是否已经启动完的




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org