You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/16 15:21:13 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #13980: [BEAM-11659][BEAM-11963] Add new schema types to Pub/Sub SQL

TheNeuralBit commented on a change in pull request #13980:
URL: https://github.com/apache/beam/pull/13980#discussion_r595273081



##########
File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/KafkaTableProviderIT.java
##########
@@ -210,7 +210,7 @@ public void testFakeNested() throws InterruptedException {
     String createTableString =
         String.format(
             "CREATE EXTERNAL TABLE kafka_table(\n"
-                + "headers ARRAY<ROW<key VARCHAR, values ARRAY<BYTES>>>,"
+                + "headers ARRAY<ROW<key VARCHAR, `values` ARRAY<VARBINARY>>>,"

Review comment:
       Is this still necessary after https://github.com/apache/beam/pull/14205?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org