PATCH: clarification to 'HACKING'

[Julian Foad <ju...@btopenworld.com>]

(Re-posting; originally posted 2003-11-26.)

I thought this bit of HACKING was misleading: it implied that all standard library string functions were unacceptable, but I think only the ones that write to strings are unacceptable whereas "strchr" etc. are OK.

[[[
Clarify, in HACKING, which string functions are acceptable.
]]]

Index: HACKING
===================================================================
--- HACKING     (revision 7857)
+++ HACKING     (working copy)
@@ -308,8 +308,8 @@ invoked with improper values.

String operations

-Use only the string functions provided in apr_strings.h.  These are
-replacements for standard C library string functions, except safer
+Use the string functions provided in apr_strings.h instead of standard
+C library functions that write to strings.  The APR functions are safer
because they do bounds-checking and dest allocation automatically.
Although there may be circumstances where it's theoretically safe to
use plain C string functions (such as when you already know the



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org