You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "vvysotskyi (GitHub)" <gi...@apache.org> on 2018/08/23 09:45:27 UTC

[GitHub] [drill] vvysotskyi opened pull request #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Initially to handle unnest with complex calls was introduced `ProjectComplexRexNodeCorrelateTransposeRule`. But this rule only matched `LogicalCorrelate -> Uncollect -> LogicalProject` pattern. So all other combinations, which have `LogicalCorrelate`, `Uncollect` and `LogicalProject` with rel nodes between `LogicalCorrelate` and `Uncollect` weren't handled.

The solution proposed in this PR is to make visitor based on `ProjectComplexRexNodeCorrelateTransposeRule` and apply it before applying rules, so all possible cases will be handled correctly.

For details please see [DRILL-6703](https://issues.apache.org/jira/browse/DRILL-6703).

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] vvysotskyi commented on pull request #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "vvysotskyi (GitHub)" <gi...@apache.org>.
Added `testMultiLateralWithComplexProject`.

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] HanumathRao commented on pull request #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "HanumathRao (GitHub)" <gi...@apache.org>.
why is this assert required? Is it better to have a if clause and return instead of assert?

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] asfgit closed pull request #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "asfgit (GitHub)" <gi...@apache.org>.
[ pull request closed by asfgit ]

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] arina-ielchiieva commented on issue #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "arina-ielchiieva (GitHub)" <gi...@apache.org>.
@HanumathRao could you please review?

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] HanumathRao commented on pull request #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "HanumathRao (GitHub)" <gi...@apache.org>.
Can you add a test case with multi lateral.

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] vvysotskyi commented on pull request #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "vvysotskyi (GitHub)" <gi...@apache.org>.
Agree with you. I remember some of checks at the validation stage, but one more wouldn't be excessive.
Added in the code above.

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] vvysotskyi commented on pull request #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "vvysotskyi (GitHub)" <gi...@apache.org>.
In the case, if at this point we have something that differs from Project, then something went wrong.

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] HanumathRao commented on pull request #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "HanumathRao (GitHub)" <gi...@apache.org>.
Assuming that only one project expression is present at this point, Is it better to have an assert here to make sure that only one proj expression is added?

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] vvysotskyi commented on issue #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "vvysotskyi (GitHub)" <gi...@apache.org>.
@HanumathRao thanks for the review!

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [drill] HanumathRao commented on issue #1441: DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Posted by "HanumathRao (GitHub)" <gi...@apache.org>.
Thanks for making the changes. Changes look good to me.

[ Full content available at: https://github.com/apache/drill/pull/1441 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org