[GitHub] [kylin] shaofengshi commented on a change in pull request #528: KYLIN-3883 Kylin supports column count aggregation

[GitBox <gi...@apache.org>]

shaofengshi commented on a change in pull request #528: KYLIN-3883 Kylin supports column count aggregation
URL: https://github.com/apache/kylin/pull/528#discussion_r268026280
 
 

 ##########
 File path: core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
 ##########
 @@ -316,12 +321,22 @@ public boolean equals(Object obj) {
             } else {
                 return parameter.equalInArbitraryOrder(other.parameter);
             }
-        } else if (!isCount()) { // NOTE: don't check the parameter of count()
+        } else {
             if (parameter == null) {
-                if (other.parameter != null)
+                if (isCount()) {
+                    if (other.parameter != null && !other.parameter.getType().equals("constant")) {
 
 Review comment:
   Please use static constant: org.apache.kylin.metadata.model.FunctionDesc#PARAMETER_TYPE_CONSTANT

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services