You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/05/29 19:10:26 UTC
[GitHub] [spark] MaxGekk commented on a diff in pull request #41368: [WIP][SQL] Improve suggested candidates for unresolved attribute
MaxGekk commented on code in PR #41368:
URL: https://github.com/apache/spark/pull/41368#discussion_r1209517197
##########
sql/core/src/test/resources/sql-tests/results/identifier-clause.sql.out:
##########
@@ -535,7 +535,7 @@ Catalog Name spark_catalog
Comment some comment
Location [not included in comparison]/{warehouse_dir}/someloc
Namespace Name ident
-Owner runner
+Owner maximgekk
Review Comment:
Probably it is related to https://github.com/apache/spark/pull/41007. @srielau @gengliangwang Is it possible to rewrite the test in a way to don't depend of local settings. Otherwise it will bother every time while re-generating golden files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org