You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by merrimanr <gi...@git.apache.org> on 2016/05/04 17:42:19 UTC
[GitHub] incubator-metron pull request: Metron 129 Create dev image
GitHub user merrimanr opened a pull request:
https://github.com/apache/incubator-metron/pull/105
Metron 129 Create dev image
Changes to create image for Hackathon on 5/4
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-129
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit c9f8b182270e21c50acbda2d5e655ee97bebb89d
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-05-03T16:44:12Z
METRON-129: Create dev image
commit 350310ecb301b6f04113304c89c9a5a38d9b5b9f
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-05-04T13:00:10Z
Merge remote-tracking branch 'apache/master' into METRON-129
commit ab775b60cc922efc1cd60af39f11bf7452eb3e16
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-05-04T14:09:22Z
METRON-133: ParserBolt is not failing tuples when parsing fails
commit 639481e485dfdfad76818a4b722af0d668456200
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-05-04T16:10:49Z
Merge remote-tracking branch 'apache/master' into METRON-129
Conflicts:
metron-deployment/playbooks/metron_install.yml
commit e39d5af4287425c9cf890ae36bfc185618402e47
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-05-04T16:16:15Z
Merge branch 'METRON-133' into METRON-129
commit 11643a6776476380cc64d1fa00371ae48bcb7081
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-05-04T17:33:46Z
renamed directory and launch script
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217073422
How do you foresee `metron-deployment/vagrant/hackathon-image-vagrant` being used after the Hackathon? Should we call it something else that is more descriptive?
It would also be good to see a README in there describing its purpose. It doesn't have to be anything fancy. I did the same with `metron-deployment/vagrant/fastcapa-vagrant/README.md`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217170847
Will add a README and fix the file name. In regards to the suggestion from @nickwallen to name the image something more appropriate (I agree with him there), does anyone have suggestions for a different name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217449552
And whatever naming convention we come up with, we will want to change `metron-deployment/vagrant/fastcapa-vagrant` to match.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217173940
Just to help frame the naming conversation, here is how 'single-node-vagrant' differs from the contribution of this PR.
- `vagrant/singlenode-vagrant` builds from scratch a complete developer image.
- `vagrant/hackathon-image-vagrant` downloads a pre-built image from Atlas saving gobs and gobs of time
Correct me, if this is not the best description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217174124
How does `hackathon-image-vagrant` differ from `devimage-vagrant`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217463020
I'm good with those @nickwallen - though for ease of tabcomplete, could we do the following?
quick-dev-platform
full-dev-platform
singlenode
codelab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217496481
Still +1. Good stuff!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/105#discussion_r62188483
--- Diff: metron-deployment/vagrant/hackathon-image-vagrant/VagrantFile ---
@@ -0,0 +1,94 @@
+#
--- End diff --
@merrimanr - could you change the filename to Vagrantfile (small 'f'). It will mostly work, but evidently there are some corner cases where the filename is strictly case sensitive and needs to be Vagrantfile.
[https://www.vagrantup.com/docs/vagrantfile/](url)
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217469486
@nickwallen - not at all. It's all c-tab to me. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217467714
Is codelab-platform too much? Just seeking a sense of symmetry with the others, but it could be overkill.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217174926
@nickwallen - that's exactly right from my POV. Here's the use cases I had in mind for each:
+ ``` vagrant/singlenode-vagrant``` - useful for testing full deploys
+ ``` vagrant/devimage-vagrant``` - preloaded with full HDP, deploys Metron. Useful for devs testing changes to Metron.
+ ``` vagrant/codelab-vagrant``` - (this is a name recommendation for the hackathon image) preloaded with light HDP (no SNN, Yarn, MR2) and Storm topologies loaded but disabled. Good for tutorials and GrokParser testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217452469
We could also swap the word image with environment, platform, or even app.
- dev-platform-full
- dev-platform-quick
This might also let us dovetail a future rename of `metron-deployment/amazon-ec2` nicely.
- ec2-cloud-platform
- ec2-cloud-platform-quick
Ok, I am done with naming suggestions. Have to stop before I start looking up synonyms for platform or environment in Esparanto or Latin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217472073
Great. To be explicit this is what has been suggested.
- `singlenode-vagrant` -> `full-dev-platform`
- `devimage-vagrant` -> `quick-dev-platform`
- `hackathon-image-vagrant` -> `codelab-platform`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217448832
Suggestions...
`singlenode-vagrant` -> `dev-image` or `dev-image-full`
`devimage-vagrant` -> `dev-image-quick`
Do we even need the `*-vagrant` part of the naming convention since all of these exist within the `metron-deployment/vagrant` directory already?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217472104
We can tackle `fastcapa-vagrant` and `multinode-vagrant` in another PR, unless @merrimanr is really motivated to tackle that too. My suggestions for those...
- `fastcapa-vagrant` -> `fastcapa-test-platform`
- 'multinode-vagrant` -> /dev/null
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217199820
It might make sense to rename singlenode and devimage so that they are more similar since they result in the same image just in different ways. Trying to think of good names...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217493364
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-216953203
+1 worked well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Metron 129 Create dev image
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the pull request:
https://github.com/apache/incubator-metron/pull/105#issuecomment-217489342
Changes based on discussion above have been pushed out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---