You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/17 22:49:04 UTC

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #3092: esp32_allocateheap.c: Don't allocate ROM regions when running in QEMU.

Ouss4 opened a new pull request #3092:
URL: https://github.com/apache/incubator-nuttx/pull/3092


   ## Summary
   This PR fixes instabilities found when running ostest in QEMU with SMP.
   ## Impact
   ESP32/QEMU/SMP
   ## Testing
   esp32-devkitc:smp + ostest
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3092: esp32_allocateheap.c: Don't allocate ROM regions when running in QEMU.

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #3092:
URL: https://github.com/apache/incubator-nuttx/pull/3092#issuecomment-801522141


   @Ouss4 
   
   Thanks!
   It works with QEMU now.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3092: esp32_allocateheap.c: Don't allocate ROM regions when running in QEMU.

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #3092:
URL: https://github.com/apache/incubator-nuttx/pull/3092#issuecomment-801709673


   > a curious question: besides qemu, can there be different ROM versions with different ROM area usage?
   
   @yamt Generally speaking, yes. Different ECO versions can have different ROM area usage.  However, this is not the case for ESP32.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 merged pull request #3092: esp32_allocateheap.c: Don't allocate ROM regions when running in QEMU.

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #3092:
URL: https://github.com/apache/incubator-nuttx/pull/3092


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3092: esp32_allocateheap.c: Don't allocate ROM regions when running in QEMU.

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #3092:
URL: https://github.com/apache/incubator-nuttx/pull/3092#issuecomment-801492234


   @masayuki2009 I basically had to revert what I did last time but only for QEMU.  This looks too hacky, I'll try to push to fix the issue from the QEMU side.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] yamt commented on pull request #3092: esp32_allocateheap.c: Don't allocate ROM regions when running in QEMU.

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #3092:
URL: https://github.com/apache/incubator-nuttx/pull/3092#issuecomment-801521795


   a curious question: besides qemu, can there be different ROM versions with different ROM area usage?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org