You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/06/08 11:29:50 UTC
[GitHub] codecov-io commented on issue #1906: unit test for UrlUtils
codecov-io commented on issue #1906: unit test for UrlUtils
URL: https://github.com/apache/incubator-dubbo/pull/1906#issuecomment-395733239
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1906?src=pr&el=h1) Report
> Merging [#1906](https://codecov.io/gh/apache/incubator-dubbo/pull/1906?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/88aa3b5af42779009f30a1be7155aeca4db06d46?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/1906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1906 +/- ##
============================================
+ Coverage 49.4% 49.54% +0.14%
- Complexity 4491 4505 +14
============================================
Files 558 558
Lines 24346 24346
Branches 4315 4315
============================================
+ Hits 12027 12062 +35
+ Misses 10474 10424 -50
- Partials 1845 1860 +15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1906?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1906/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `77.77% <0%> (-11.12%)` | `5% <0%> (-2%)` | |
| [...on/src/main/java/com/alibaba/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1906/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL1VSTC5qYXZh) | `26.64% <0%> (+0.29%)` | `80% <0%> (+2%)` | :arrow_up: |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1906/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `55.69% <0%> (+3.79%)` | `13% <0%> (+3%)` | :arrow_up: |
| [.../java/com/alibaba/dubbo/common/utils/UrlUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1906/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL1VybFV0aWxzLmphdmE=) | `75.98% <0%> (+8.6%)` | `74% <0%> (+10%)` | :arrow_up: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1906/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `84.61% <0%> (+11.53%)` | `8% <0%> (ø)` | :arrow_down: |
| [...va/com/alibaba/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1906/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvRHViYm9TaHV0ZG93bkhvb2suamF2YQ==) | `73.91% <0%> (+30.43%)` | `6% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1906?src=pr&el=footer). Last update [88aa3b5...3846f47](https://codecov.io/gh/apache/incubator-dubbo/pull/1906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org