[GitHub] [trafficserver] maskit commented on a diff in pull request #9767: Filter SNI based on port

["maskit (via GitHub)" <gi...@apache.org>]

maskit commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1237259521


##########
iocore/net/TLSSNISupport.cc:
##########
@@ -64,8 +67,12 @@ TLSSNISupport::perform_sni_action()
   }
 
   SNIConfig::scoped_config params;
-  if (const auto &actions = params->get({servername, std::strlen(servername)}); !actions.first) {
-    Debug("ssl_sni", "%s not available in the map", servername);
+  // should always work in this context of SSL action callbacks
+  SSLNetVConnection *ssl_vc{dynamic_cast<SSLNetVConnection *>(this)};

Review Comment:
   This is not great. What requires this cast?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org