You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@hotmail.com> on 2013/08/24 01:09:17 UTC
Review Request 13785: [HELIX-214] User-defined rebalancer should never use
SEMI_AUTO code paths
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13785/
-----------------------------------------------------------
Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
Bugs: HELIX-214
Repository: helix-git
Description
-------
commit e3f3c1658a9c6ce125e2be31c4fe4f9a4c83deb1
Author: Kanak Biscuitwala <ka...@hotmail.com>
Date: Fri Aug 23 15:59:03 2013 -0700
[HELIX-214] User-defined rebalancer should never use SEMI_AUTO code paths
:100644 100644 08a8208... 40db900... M helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
:100644 100644 59bc59c... e14940a... M helix-core/src/main/java/org/apache/helix/model/IdealState.java
:100644 100644 70ff6bd... 55fc876... M helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 08a8208
helix-core/src/main/java/org/apache/helix/model/IdealState.java 59bc59c
helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java 70ff6bd
Diff: https://reviews.apache.org/r/13785/diff/
Testing
-------
Modified test passes and more accurately ensures that the user-defined rebalancer is doing the right thing.
Thanks,
Kanak Biscuitwala
Re: Review Request 13785: [HELIX-214] User-defined rebalancer should never
use SEMI_AUTO code paths
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13785/#review25520
-----------------------------------------------------------
Ship it!
Ship It!
- Kishore Gopalakrishna
On Aug. 23, 2013, 11:09 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13785/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2013, 11:09 p.m.)
>
>
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-214
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit e3f3c1658a9c6ce125e2be31c4fe4f9a4c83deb1
> Author: Kanak Biscuitwala <ka...@hotmail.com>
> Date: Fri Aug 23 15:59:03 2013 -0700
>
> [HELIX-214] User-defined rebalancer should never use SEMI_AUTO code paths
>
> :100644 100644 08a8208... 40db900... M helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
> :100644 100644 59bc59c... e14940a... M helix-core/src/main/java/org/apache/helix/model/IdealState.java
> :100644 100644 70ff6bd... 55fc876... M helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 08a8208
> helix-core/src/main/java/org/apache/helix/model/IdealState.java 59bc59c
> helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java 70ff6bd
>
> Diff: https://reviews.apache.org/r/13785/diff/
>
>
> Testing
> -------
>
> Modified test passes and more accurately ensures that the user-defined rebalancer is doing the right thing.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>