You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by bi...@apache.org on 2017/06/22 14:11:33 UTC
kylin git commit: KYLIN-2678 fix error in test case KylinConfigCLITest
Repository: kylin
Updated Branches:
refs/heads/master 5749aed4e -> 2d1a47d1b
KYLIN-2678 fix error in test case KylinConfigCLITest
Signed-off-by: wangxianbin1987 <wa...@gmail.com>
Signed-off-by: Billy Liu <bi...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/2d1a47d1
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/2d1a47d1
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/2d1a47d1
Branch: refs/heads/master
Commit: 2d1a47d1be28e47a143c42b2a885c10725228b91
Parents: 5749aed
Author: wangxianbin1987 <wa...@gmail.com>
Authored: Wed Jun 21 17:54:57 2017 +0800
Committer: Billy Liu <bi...@apache.org>
Committed: Thu Jun 22 22:00:43 2017 +0800
----------------------------------------------------------------------
.../java/org/apache/kylin/tool/KylinConfigCLITest.java | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/2d1a47d1/tool/src/test/java/org/apache/kylin/tool/KylinConfigCLITest.java
----------------------------------------------------------------------
diff --git a/tool/src/test/java/org/apache/kylin/tool/KylinConfigCLITest.java b/tool/src/test/java/org/apache/kylin/tool/KylinConfigCLITest.java
index 7d1e248..feb404a 100644
--- a/tool/src/test/java/org/apache/kylin/tool/KylinConfigCLITest.java
+++ b/tool/src/test/java/org/apache/kylin/tool/KylinConfigCLITest.java
@@ -37,12 +37,13 @@ public class KylinConfigCLITest extends LocalFileMetadataTestCase {
public void testGetProperty() throws IOException {
PrintStream o = System.out;
File f = File.createTempFile("cfg", ".tmp");
- System.setOut(new PrintStream(new FileOutputStream(f)));
+ PrintStream tmpOut = new PrintStream(new FileOutputStream(f));
+ System.setOut(tmpOut);
KylinConfigCLI.main(new String[] { "kylin.storage.url" });
String val = FileUtils.readFileToString(f, Charset.defaultCharset()).trim();
assertEquals("hbase", val);
-
+ tmpOut.close();
FileUtils.forceDelete(f);
System.setOut(o);
}
@@ -51,12 +52,15 @@ public class KylinConfigCLITest extends LocalFileMetadataTestCase {
public void testGetPrefix() throws IOException {
PrintStream o = System.out;
File f = File.createTempFile("cfg", ".tmp");
- System.setOut(new PrintStream(new FileOutputStream(f)));
+ PrintStream tmpOut = new PrintStream(new FileOutputStream(f));
+ System.setOut(tmpOut);
KylinConfigCLI.main(new String[] { "kylin.cube.engine." });
String val = FileUtils.readFileToString(f, Charset.defaultCharset()).trim();
- assertEquals("2=org.apache.kylin.engine.mr.MRBatchCubingEngine2\n0=org.apache.kylin.engine.mr.MRBatchCubingEngine", val);
+ assertEquals("2=org.apache.kylin.engine.mr.MRBatchCubingEngine2"
+ + System.lineSeparator() + "0=org.apache.kylin.engine.mr.MRBatchCubingEngine", val);
+ tmpOut.close();
FileUtils.forceDelete(f);
System.setOut(o);
}