You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/26 20:21:17 UTC
[GitHub] [thrift] cfriedt opened a new pull request, #2682: lib: cpp: thrift: include functional in TServerFramework
cfriedt opened a new pull request, #2682:
URL: https://github.com/apache/thrift/pull/2682
<!-- Explain the changes in the pull request below: -->
Use of `std::placeholders::_1` requires `<functional>`.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
No
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
No
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
Yes
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-
Change"?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] cfriedt commented on pull request #2682: lib: cpp: thrift: include functional in TServerFramework
Posted by GitBox <gi...@apache.org>.
cfriedt commented on PR #2682:
URL: https://github.com/apache/thrift/pull/2682#issuecomment-1287836580
rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G merged pull request #2682: lib: cpp: thrift: include functional in TServerFramework
Posted by GitBox <gi...@apache.org>.
Jens-G merged PR #2682:
URL: https://github.com/apache/thrift/pull/2682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] cfriedt commented on pull request #2682: lib: cpp: thrift: include functional in TServerFramework
Posted by GitBox <gi...@apache.org>.
cfriedt commented on PR #2682:
URL: https://github.com/apache/thrift/pull/2682#issuecomment-1289810461
> Would still. be nice to know the purpose. Even if it is only a one-liner.
I was getting a compile error. Some details in https://github.com/zephyrproject-rtos/gsoc-2022-thrift/issues/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2682: lib: cpp: thrift: include functional in TServerFramework
Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2682:
URL: https://github.com/apache/thrift/pull/2682#issuecomment-1288061402
Would still. be nice to know the purpose. Even if it is only a one-liner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org