You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/25 08:48:23 UTC

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4501: Disallowing udp for lb rules

weizhouapache commented on a change in pull request #4501:
URL: https://github.com/apache/cloudstack/pull/4501#discussion_r530198051



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java
##########
@@ -255,6 +255,12 @@ public Boolean getOpenFirewall() {
     }
 
     public String getLbProtocol() {
+        if (lbProtocol != null) {
+            lbProtocol = lbProtocol.toLowerCase();
+            if (!lbProtocol.equals(NetUtils.TCP_PROTO) && !lbProtocol.equals(NetUtils.TCP_PROXY_PROTO)) {
+                throw new InvalidParameterValueException("Invalid protocool. Supported protocols are tcp and tcp-proxy");

Review comment:
       @davidjumani as far as I remember, 'ssl' is also a valid protocol
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org