You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/04/22 16:45:49 UTC
[lang] [LANG-1394] org.apache.commons.lang3.SystemUtils should not
write to System.err.
Repository: commons-lang
Updated Branches:
refs/heads/master 7c441e87c -> 58a8f12b4
[LANG-1394] org.apache.commons.lang3.SystemUtils should not write to
System.err.
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/58a8f12b
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/58a8f12b
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/58a8f12b
Branch: refs/heads/master
Commit: 58a8f12b443d7cbc16ec00b8841138ee55ee6630
Parents: 7c441e8
Author: Gary Gregory <gg...@apache.org>
Authored: Sun Apr 22 10:45:43 2018 -0600
Committer: Gary Gregory <gg...@apache.org>
Committed: Sun Apr 22 10:45:43 2018 -0600
----------------------------------------------------------------------
src/changes/changes.xml | 1 +
src/main/java/org/apache/commons/lang3/SystemUtils.java | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/58a8f12b/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 4ec1984..69d194f 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -60,6 +60,7 @@ The <action> type attribute can be add,update,fix,remove.
<action issue="LANG-1356" type="add" dev="pschumacher" due-to="Yathos UG">Add bypass option for classes to recursive and reflective EqualsBuilder</action>
<action issue="LANG-1391" type="add" dev="ggregory" due-to="Sauro Matulli, Oleg Chubaryov">Improve Javadoc for StringUtils.isAnyEmpty(null)</action>
<action issue="LANG-1393" type="add" dev="ggregory" due-to="Gary Gregory">Add API SystemUtils.String getEnvironmentVariable(final String name, final String defaultValue)</action>
+ <action issue="LANG-1394" type="add" dev="ggregory" due-to="Sebb, Gary Gregory">org.apache.commons.lang3.SystemUtils should not write to System.err.</action>
</release>
<release version="3.7" date="2017-11-04" description="New features and bug fixes. Requires Java 7, supports Java 8, 9, 10.">
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/58a8f12b/src/main/java/org/apache/commons/lang3/SystemUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/SystemUtils.java b/src/main/java/org/apache/commons/lang3/SystemUtils.java
index 8a1ac9c..5e9e44f 100644
--- a/src/main/java/org/apache/commons/lang3/SystemUtils.java
+++ b/src/main/java/org/apache/commons/lang3/SystemUtils.java
@@ -1599,8 +1599,8 @@ public class SystemUtils {
return System.getProperty(property);
} catch (final SecurityException ex) {
// we are not allowed to look at this property
- System.err.println("Caught a SecurityException reading the system property '" + property
- + "'; the SystemUtils property value will default to null.");
+ // System.err.println("Caught a SecurityException reading the system property '" + property
+ // + "'; the SystemUtils property value will default to null.");
return null;
}
}
@@ -1627,7 +1627,7 @@ public class SystemUtils {
return value == null ? defaultValue : value;
} catch (final SecurityException ex) {
// we are not allowed to look at this property
- System.err.println("Caught a SecurityException reading the environment variable '" + name + "'.");
+ // System.err.println("Caught a SecurityException reading the environment variable '" + name + "'.");
return defaultValue;
}
}