You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2018/11/01 09:00:12 UTC

Review Request 69226: ATLAS-2949 : Remove duplicate attribute from the rdbms entity

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69226/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-2949
    https://issues.apache.org/jira/browse/ATLAS-2949


Repository: atlas


Description
-------

Remove Asset from the superTypes list of the entity RDBMS because Dataset is derived from the Asset type


Diffs
-----

  addons/models/2000-RDBMS/2010-rdbms_model.json 7d1747bdf 
  addons/models/2000-RDBMS/patches/001-rdbms_column_table_add_options.json 202fadec2 


Diff: https://reviews.apache.org/r/69226/diff/1/


Testing
-------

Done one round of testing and check the UI now duplicate attributes are removed.


Thanks,

keval bhatt


Re: Review Request 69226: ATLAS-2949 : Remove duplicate attribute from the rdbms entity

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69226/#review211606
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Nov. 1, 2018, 2 a.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69226/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2018, 2 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2949
>     https://issues.apache.org/jira/browse/ATLAS-2949
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Remove Asset from the superTypes list of the entity RDBMS because Dataset is derived from the Asset type
> 
> 
> Diffs
> -----
> 
>   addons/models/2000-RDBMS/2010-rdbms_model.json 7d1747bdf 
>   addons/models/2000-RDBMS/patches/001-rdbms_column_table_add_options.json 202fadec2 
> 
> 
> Diff: https://reviews.apache.org/r/69226/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of testing and check the UI now duplicate attributes are removed.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>


Re: Review Request 69226: ATLAS-2949 : Remove duplicate attribute from the rdbms entity

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69226/#review210251
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On Nov. 1, 2018, 9 a.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69226/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2018, 9 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2949
>     https://issues.apache.org/jira/browse/ATLAS-2949
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Remove Asset from the superTypes list of the entity RDBMS because Dataset is derived from the Asset type
> 
> 
> Diffs
> -----
> 
>   addons/models/2000-RDBMS/2010-rdbms_model.json 7d1747bdf 
>   addons/models/2000-RDBMS/patches/001-rdbms_column_table_add_options.json 202fadec2 
> 
> 
> Diff: https://reviews.apache.org/r/69226/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of testing and check the UI now duplicate attributes are removed.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>


Re: Review Request 69226: ATLAS-2949 : Remove duplicate attribute from the rdbms entity

Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69226/
-----------------------------------------------------------

(Updated Jan. 14, 2019, 6:47 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-2949
    https://issues.apache.org/jira/browse/ATLAS-2949


Repository: atlas


Description
-------

Remove Asset from the superTypes list of the entity RDBMS because Dataset is derived from the Asset type


Diffs (updated)
-----

  addons/models/2000-RDBMS/2010-rdbms_model.json 8fe185d4b 
  addons/models/2000-RDBMS/patches/001-rdbms_column_table_add_options.json 202fadec2 
  addons/models/2000-RDBMS/patches/002-rdbms_model_add_service_type.json 6a153e494 


Diff: https://reviews.apache.org/r/69226/diff/2/

Changes: https://reviews.apache.org/r/69226/diff/1-2/


Testing
-------

Done one round of testing and check the UI now duplicate attributes are removed.


Thanks,

keval bhatt