You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/18 03:32:34 UTC
[GitHub] [apisix] starsz opened a new pull request #3074: fix: bad server_info example
starsz opened a new pull request #3074:
URL: https://github.com/apache/apisix/pull/3074
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
Because the `report_interval` minimum is 60. So it's a bad example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3074: fix: bad server_info example
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3074:
URL: https://github.com/apache/apisix/pull/3074#discussion_r545606572
##########
File path: doc/zh-cn/plugins/server-info.md
##########
@@ -77,13 +77,13 @@ plugins: # plugin list
| report_interval | integer | 60 | 上报服务信息至 etcd 的间隔（单位：秒，最大值：3600，最小值：60）|
| report_ttl | integer | 7200 | etcd 中服务信息保存的 TTL（单位：秒，最大值：86400，最小值：3600）|
-下面的例子将 `report_interval` 修改成了 10 秒，并将 `report_ttl` 修改成了 1
+下面的例子将 `report_interval` 修改成了 10 分钟，并将 `report_ttl` 修改成了 1
Review comment:
@starsz
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3074: fix: bad server_info example
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3074:
URL: https://github.com/apache/apisix/pull/3074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3074: fix: bad server_info example
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #3074:
URL: https://github.com/apache/apisix/pull/3074#discussion_r545601772
##########
File path: doc/zh-cn/plugins/server-info.md
##########
@@ -77,13 +77,13 @@ plugins: # plugin list
| report_interval | integer | 60 | 上报服务信息至 etcd 的间隔（单位：秒，最大值：3600，最小值：60）|
| report_ttl | integer | 7200 | etcd 中服务信息保存的 TTL（单位：秒，最大值：86400，最小值：3600）|
-下面的例子将 `report_interval` 修改成了 10 秒，并将 `report_ttl` 修改成了 1
+下面的例子将 `report_interval` 修改成了 10 分钟，并将 `report_ttl` 修改成了 1
Review comment:
I had checked. English version is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3074: fix: bad server_info example
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3074:
URL: https://github.com/apache/apisix/pull/3074#discussion_r545556142
##########
File path: doc/zh-cn/plugins/server-info.md
##########
@@ -77,13 +77,13 @@ plugins: # plugin list
| report_interval | integer | 60 | 上报服务信息至 etcd 的间隔（单位：秒，最大值：3600，最小值：60）|
| report_ttl | integer | 7200 | etcd 中服务信息保存的 TTL（单位：秒，最大值：86400，最小值：3600）|
-下面的例子将 `report_interval` 修改成了 10 秒，并将 `report_ttl` 修改成了 1
+下面的例子将 `report_interval` 修改成了 10 分钟，并将 `report_ttl` 修改成了 1
Review comment:
Should we change the English version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org