[GitHub] [hadoop-submarine] liuxunorg commented on a change in pull request #22: SUBMARINE-207. Exclude mysql jdbc jar from the path of workbench/lib.

[GitBox <gi...@apache.org>]

liuxunorg commented on a change in pull request #22: SUBMARINE-207. Exclude mysql jdbc jar from the path of workbench/lib.
URL: https://github.com/apache/hadoop-submarine/pull/22#discussion_r331781717
 
 

 ##########
 File path: bin/workbench-daemon.sh
 ##########
 @@ -88,6 +89,23 @@ function wait_for_workbench_to_die() {
   fi
 }
 
+function check_jdbc_jar() {
+  if [[ -d "${1}" ]]; then
+    mysql_connector_exists=$(find -L "${1}" -name "mysql-connector*")
+    if [[ -z "${mysql_connector_exists}" ]]; then
+      if [[ ${GET_MYSQL_JAR} = true ]]; then
+        download_mysql_jdbc_jar
+      else
+        echo -e "\\033[31mError: There is no mysql jdbc jar in workbench/lib.\\033[0m"
+        echo -e "\\033[31mPlease download a mysql jdbc jar and put it under workbench/lib manually.\\033[0m"
+        echo -e "\\033[31mOr add a parameter getMysqlJar, like this:\nworkbench-daemon.sh start getMysqlJar\\033[0m"
 
 Review comment:
   Change to 
   `like this:\n./bin/workbench-daemon.sh start getMysqlJar ??`
   or
   `like this:\n./workbench-daemon.sh start getMysqlJar ??`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services