[GitHub] [druid] clintropolis commented on a change in pull request #9111: Add HashJoinSegment, a virtual segment for joins.

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #9111: Add HashJoinSegment, a virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#discussion_r367208666
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableColumnValueSelector.java
 ##########
 @@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.segment.join.table;
+
+import org.apache.druid.common.config.NullHandling;
+import org.apache.druid.query.monomorphicprocessing.RuntimeShapeInspector;
+import org.apache.druid.segment.ColumnValueSelector;
+
+import javax.annotation.Nullable;
+import java.util.function.IntSupplier;
+
+public class IndexedTableColumnValueSelector implements ColumnValueSelector<Object>
+{
+  private final IntSupplier currentRow;
+  private final IndexedTable.Reader columnReader;
+
+  IndexedTableColumnValueSelector(IndexedTable table, IntSupplier currentRow, int columnNumber)
+  {
+    this.currentRow = currentRow;
+    this.columnReader = table.columnReader(columnNumber);
+  }
+
+  @Override
+  public double getDouble()
+  {
+    final int rowNum = currentRow.getAsInt();
+
+    if (rowNum != -1) {
+      final Object value = columnReader.read(currentRow.getAsInt());
+
+      if (value instanceof Number) {
+        return ((Number) value).doubleValue();
+      }
+    }
+
+    // Otherwise this shouldn't have been called (due to isNull returning true).
+    assert NullHandling.replaceWithDefault();
+    return NullHandling.defaultDoubleValue();
 
 Review comment:
   Will this and other primitive get methods cause a null pointer exception if it does happen to get called in production-ish environment and sql compatible null handling is enabled because the assert will not be executed and `NullHandling.defaultDoubleValue()` will return `null`. Should this return the 0 value instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org