You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/23 09:09:45 UTC
[GitHub] [skywalking] thomasbryant1024 opened a new issue #4696: contribute apm-sniffer resttemplate-4.x-plugin
thomasbryant1024 opened a new issue #4696:
URL: https://github.com/apache/skywalking/issues/4696
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement
___
### Question
- What do you want to know?
Hi，I enhance the resttemplate-4.x-plugin's function.That is to add the function of collecting the response of resttemplate which controlled by the system env variable named 'plugin.resttemplate.collect_http_response' .I tried to commit the code,but it shows me that I
have no permission to push the feautre. How I can contribute the code?
___
### Bug
- Which version of SkyWalking, OS and JRE?
- Which company or project?
- What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.
___
### Requirement or improvement
- Please describe about your requirements or improvement suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #4696: contribute apm-sniffer resttemplate-4.x-plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4696:
URL: https://github.com/apache/skywalking/issues/4696#issuecomment-618282619
> Hi，I enhance the resttemplate-4.x-plugin's function.That is to add the function of collecting the response of resttemplate which controlled by the system env variable named 'plugin.resttemplate.collect_http_response' .I tried to commit the code,but it shows me that I
have no permission to push the feautre. How I can contribute the code?
No one has that permission. You need to follow the GitHub official pull request process. Fork the repo, change the codes there, and send the pull request to the main repo.
Also, we have plugin test documentation, please follow that to make sure your new feature has been covered in plugin test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org