You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/18 14:41:45 UTC

[GitHub] [arrow] paleolimbot commented on a change in pull request #12168: ARROW-15316 [R] Make a one-function pointer function

paleolimbot commented on a change in pull request #12168:
URL: https://github.com/apache/arrow/pull/12168#discussion_r786824893



##########
File path: r/R/python.R
##########
@@ -315,3 +269,11 @@ pyarrow_version <- function() {
 }
 
 pyarrow_version_pointers_changed <- "7.0.0"
+
+backwards_compatible_pointer_double <- function(ptr) {

Review comment:
       The name of this is a bit misleading since it doesn't always return a `double`...maybe `pyarrow_compatible_ptr()`? You could also wrap the `pyarrow_version_pointers_changed` and `pyarrow_version()` bits into the function too since it's the only place they are used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org