You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "arjun4084346 (via GitHub)" <gi...@apache.org> on 2023/07/22 00:05:10 UTC
[GitHub] [gobblin] arjun4084346 opened a new pull request, #3722: Correct num of failures
arjun4084346 opened a new pull request, #3722:
URL: https://github.com/apache/gobblin/pull/3722
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1860
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
When job fails during workunit creation, it sets the job state as FAILED, but does not set JOB_FAILURES_KEY.
It also does not have datasets created if it fails at such an early stage and the current code relies on dataset state's properties to find the failure count.
This PR will set the config JOB_FAILURES_KEY when the job fails.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
trivial change
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3722: Correct num of failures
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3722:
URL: https://github.com/apache/gobblin/pull/3722#issuecomment-1648344078
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3722?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3722](https://app.codecov.io/gh/apache/gobblin/pull/3722?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (39778ee) into [master](https://app.codecov.io/gh/apache/gobblin/commit/0151890d1f5274fb86827074a755e54adf189ba0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0151890) will **increase** coverage by `3.20%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3722 +/- ##
============================================
+ Coverage 46.95% 50.15% +3.20%
+ Complexity 10811 5833 -4978
============================================
Files 2143 1070 -1073
Lines 84557 41015 -43542
Branches 9390 4596 -4794
============================================
- Hits 39704 20572 -19132
+ Misses 41235 18655 -22580
+ Partials 3618 1788 -1830
```
| [Impacted Files](https://app.codecov.io/gh/apache/gobblin/pull/3722?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://app.codecov.io/gh/apache/gobblin/pull/3722?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `59.03% <100.00%> (+0.18%)` | :arrow_up: |
... and [1074 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3722/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3722: Correct num of failures
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3722:
URL: https://github.com/apache/gobblin/pull/3722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org