You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "vkagamlyk (via GitHub)" <gi...@apache.org> on 2023/04/18 22:02:18 UTC
[GitHub] [tinkerpop] vkagamlyk opened a new pull request, #2028: Fixed MergeV/MergeE steps to work when onCreate is immutable map
vkagamlyk opened a new pull request, #2028:
URL: https://github.com/apache/tinkerpop/pull/2028
Current implementation of MergeV/MergeE doesn't work when `Merge.onCreate` is immutable map.
https://issues.apache.org/jira/browse/TINKERPOP-2926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2028: Fixed MergeV/MergeE steps to work when onCreate is immutable map
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2028:
URL: https://github.com/apache/tinkerpop/pull/2028#issuecomment-1514037721
## [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2028?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2028](https://codecov.io/gh/apache/tinkerpop/pull/2028?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bc966a) into [3.6-dev](https://codecov.io/gh/apache/tinkerpop/commit/d0e02f1e48635316794593d71f4517c996825221?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0e02f1) will **decrease** coverage by `4.89%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.6-dev #2028 +/- ##
=============================================
- Coverage 69.39% 64.51% -4.89%
=============================================
Files 878 25 -853
Lines 42103 3793 -38310
Branches 5643 0 -5643
=============================================
- Hits 29219 2447 -26772
+ Misses 10891 1179 -9712
+ Partials 1993 167 -1826
```
[see 853 files with indirect coverage changes](https://codecov.io/gh/apache/tinkerpop/pull/2028/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #2028: Fixed MergeV/MergeE steps to work when onCreate is immutable map
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2028:
URL: https://github.com/apache/tinkerpop/pull/2028#issuecomment-1518392003
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2028: Fixed MergeV/MergeE steps to work when onCreate is immutable map
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2028:
URL: https://github.com/apache/tinkerpop/pull/2028#issuecomment-1517871002
VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on a diff in pull request #2028: Fixed MergeV/MergeE steps to work when onCreate is immutable map
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on code in PR #2028:
URL: https://github.com/apache/tinkerpop/pull/2028#discussion_r1173268942
##########
CHANGELOG.asciidoc:
##########
@@ -31,9 +31,11 @@ This release also includes changes from <<release-3-5-6, 3.5.6>>.
* Fixed bug in `GroovyTranslator` that surrounded `String` keys with parenthesis for `Map` when not necessary.
* Added support to the grammar allowing `List` and `Map` key declarations for `Map` entries.
* Improved performance of comparison (equals) between not compatible types and nulls.
+* Fixed MergeV/MergeE steps to work when onCreate is immutable map.
* Introduced `Writing` and `Deleting` marker interfaces to identify whether a step can perform write or delete or both on Graph.
* Added static map capturing possible Traversal steps that shall be added to traversal for a given operator
+
Review Comment:
small nit: added extra new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2028: Fixed MergeV/MergeE steps to work when onCreate is immutable map
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2028:
URL: https://github.com/apache/tinkerpop/pull/2028#issuecomment-1517207712
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk merged pull request #2028: Fixed MergeV/MergeE steps to work when onCreate is immutable map
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk merged PR #2028:
URL: https://github.com/apache/tinkerpop/pull/2028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org