You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/29 19:44:36 UTC
[GitHub] [incubator-superset] riahk opened a new pull request #11494: feat: annotation layers modal + filters
riahk opened a new pull request #11494:
URL: https://github.com/apache/incubator-superset/pull/11494
### SUMMARY
- [x] Add `AnnotationLayerModal` component for create/edit functionality
- [x] Fix `ListView` styles
- [x] Update annotation layer api to return `id` field
- [x] Add filters
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1209" alt="Screen Shot 2020-10-29 at 11 54 11 AM" src="https://user-images.githubusercontent.com/8216382/97624422-4cffc300-19e4-11eb-94d6-f12703f700d3.png">
<img width="1209" alt="Screen Shot 2020-10-29 at 12 41 08 PM" src="https://user-images.githubusercontent.com/8216382/97624428-4f621d00-19e4-11eb-93d3-f6dd5beb3b0b.png">
<img width="1207" alt="Screen Shot 2020-10-29 at 12 41 21 PM" src="https://user-images.githubusercontent.com/8216382/97624434-50934a00-19e4-11eb-8b82-24f306da249b.png">
### TEST PLAN
- [x] Add `AnnotationLayerModal_spec`
- [ ] Update `AnnotationLayerList_spec`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11494: feat: annotation layers modal + filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11494:
URL: https://github.com/apache/incubator-superset/pull/11494#issuecomment-718995780
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=h1) Report
> Merging [#11494](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11494 +/- ##
==========================================
- Coverage 66.61% 61.85% -4.76%
==========================================
Files 862 418 -444
Lines 41215 26079 -15136
Branches 3719 0 -3719
==========================================
- Hits 27454 16132 -11322
+ Misses 13660 9947 -3713
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.30% <100.00%> (+0.15%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | | |
| [...-frontend/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrU2NhdHRlci5qcw==) | | |
| [...t-frontend/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | | |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | | |
| ... and [442 more](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=footer). Last update [ed3dca4...618eaa8](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11494: feat: annotation layers modal + filters
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11494:
URL: https://github.com/apache/incubator-superset/pull/11494#issuecomment-718995780
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=h1) Report
> Merging [#11494](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `10.51%`.
> The diff coverage is `5.61%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11494 +/- ##
===========================================
- Coverage 66.61% 56.09% -10.52%
===========================================
Files 862 408 -454
Lines 41215 13829 -27386
Branches 3719 3530 -189
===========================================
- Hits 27454 7758 -19696
+ Misses 13660 5904 -7756
- Partials 101 167 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.09% <5.61%> (-0.34%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ews/CRUD/annotationlayers/AnnotationLayersList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJzTGlzdC50c3g=) | `4.00% <0.00%> (-80.32%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `5.06% <5.06%> (ø)` | |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `77.38% <100.00%> (-21.61%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `3.57% <0.00%> (-88.74%)` | :arrow_down: |
| ... and [687 more](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=footer). Last update [ed3dca4...4ba349e](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11494: feat: annotation layers modal + filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11494:
URL: https://github.com/apache/incubator-superset/pull/11494#issuecomment-718995780
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=h1) Report
> Merging [#11494](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11494 +/- ##
==========================================
- Coverage 66.61% 61.85% -4.76%
==========================================
Files 862 418 -444
Lines 41215 26079 -15136
Branches 3719 0 -3719
==========================================
- Hits 27454 16132 -11322
+ Misses 13660 9947 -3713
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.30% <100.00%> (+0.15%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | | |
| [...rset-frontend/src/dashboard/util/componentTypes.ts](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudFR5cGVzLnRz) | | |
| [...perset-frontend/src/dashboard/util/findParentId.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRQYXJlbnRJZC5qcw==) | | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | | |
| [...nd/src/messageToasts/components/ToastPresenter.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdFByZXNlbnRlci50c3g=) | | |
| ... and [442 more](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=footer). Last update [ed3dca4...618eaa8](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11494: feat: annotation layers modal + filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11494:
URL: https://github.com/apache/incubator-superset/pull/11494#issuecomment-718995780
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=h1) Report
> Merging [#11494](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.30%`.
> The diff coverage is `73.78%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11494 +/- ##
==========================================
- Coverage 66.61% 62.30% -4.31%
==========================================
Files 862 864 +2
Lines 41215 41326 +111
Branches 3719 3750 +31
==========================================
- Hits 27454 25748 -1706
- Misses 13660 15400 +1740
- Partials 101 178 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.76% <73.52%> (+0.06%)` | :arrow_up: |
| #python | `62.03% <100.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ews/CRUD/annotationlayers/AnnotationLayersList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJzTGlzdC50c3g=) | `80.64% <69.23%> (-3.67%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `73.86% <73.86%> (ø)` | |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `95.95% <100.00%> (-3.04%)` | :arrow_down: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.30% <100.00%> (+0.15%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=footer). Last update [ed3dca4...618eaa8](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11494: feat: annotation layers modal + filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11494:
URL: https://github.com/apache/incubator-superset/pull/11494#issuecomment-718995780
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=h1) Report
> Merging [#11494](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `5.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11494 +/- ##
==========================================
- Coverage 66.61% 61.39% -5.23%
==========================================
Files 862 418 -444
Lines 41215 26079 -15136
Branches 3719 0 -3719
==========================================
- Hits 27454 16010 -11444
+ Misses 13660 10069 -3591
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.39% <100.00%> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.30% <100.00%> (+0.15%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.30% <0.00%> (-0.84%)` | :arrow_down: |
| [superset-frontend/src/components/Hotkeys.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSG90a2V5cy5qc3g=) | | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=footer). Last update [ed3dca4...618eaa8](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11494: feat: annotation layers modal + filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11494:
URL: https://github.com/apache/incubator-superset/pull/11494#issuecomment-718995780
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=h1) Report
> Merging [#11494](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.57%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11494 +/- ##
==========================================
- Coverage 66.61% 62.03% -4.58%
==========================================
Files 862 418 -444
Lines 41215 26079 -15136
Branches 3719 0 -3719
==========================================
- Hits 27454 16178 -11276
+ Misses 13660 9901 -3759
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `62.03% <100.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.30% <100.00%> (+0.15%)` | :arrow_up: |
| [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | | |
| [...uperset-frontend/src/components/FacePile/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvdXRpbHMudHN4) | | |
| [...rontend/src/messageToasts/enhancers/withToasts.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvZW5oYW5jZXJzL3dpdGhUb2FzdHMudHN4) | | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | | |
| [...-frontend/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrU2NhdHRlci5qcw==) | | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | | |
| [...nd/src/dashboard/util/findTabIndexByComponentId.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRUYWJJbmRleEJ5Q29tcG9uZW50SWQuanM=) | | |
| [...ntend/src/components/dataViewCommon/Pagination.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vUGFnaW5hdGlvbi50c3g=) | | |
| [...uperset-frontend/src/components/Checkbox/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvaW5kZXgudHN4) | | |
| ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=footer). Last update [ed3dca4...618eaa8](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11494: feat: annotation layers modal + filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11494:
URL: https://github.com/apache/incubator-superset/pull/11494#issuecomment-718995780
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=h1) Report
> Merging [#11494](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `5.28%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11494 +/- ##
==========================================
- Coverage 66.61% 61.32% -5.29%
==========================================
Files 862 418 -444
Lines 41215 26079 -15136
Branches 3719 0 -3719
==========================================
- Hits 27454 15994 -11460
+ Misses 13660 10085 -3575
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.32% <100.00%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.30% <100.00%> (+0.15%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.46% <0.00%> (-1.68%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.86% <0.00%> (-0.49%)` | :arrow_down: |
| ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=footer). Last update [ed3dca4...618eaa8](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11494: feat: annotation layers modal + filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11494:
URL: https://github.com/apache/incubator-superset/pull/11494#issuecomment-718995780
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=h1) Report
> Merging [#11494](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed3dca420f349085065b9a7e5b8a52ed7dfe328f?el=desc) will **decrease** coverage by `4.75%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11494 +/- ##
==========================================
- Coverage 66.61% 61.85% -4.76%
==========================================
Files 862 418 -444
Lines 41215 26079 -15136
Branches 3719 0 -3719
==========================================
- Hits 27454 16131 -11323
+ Misses 13660 9948 -3712
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `61.85% <100.00%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.30% <100.00%> (+0.15%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | | |
| [...-frontend/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrU2NhdHRlci5qcw==) | | |
| [...t-frontend/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | | |
| ... and [443 more](https://codecov.io/gh/apache/incubator-superset/pull/11494/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=footer). Last update [ed3dca4...618eaa8](https://codecov.io/gh/apache/incubator-superset/pull/11494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org