You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "jwitko (via GitHub)" <gi...@apache.org> on 2023/02/09 14:43:52 UTC
[GitHub] [druid] jwitko opened a new pull request, #13783: helm: Fix PDB apiVersion to allow K8s 1.25+ deployment
jwitko opened a new pull request, #13783:
URL: https://github.com/apache/druid/pull/13783
### Description
The Apache Druid helm chart can not currently be deployed on Kubernetes v1.25+ with PodDisruptionBudgets enabled. The API Version being used (`policy/v1beta1`) has [been removed in Kubernetes 1.25](https://kubernetes.io/docs/reference/using-api/deprecation-guide/#poddisruptionbudget-v125). This PR allows for the updated policy version when helm can determine that the cluster version is `>1.21` (when the API was deprecated). It also paves the way for a place and style to do other changes of this nature.
#### Release note
Fix broken helm chart deployments using PodDisruptionBudget for Kubernetes 1.25+
This PR has:
- [X] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [X] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jwitko commented on pull request #13783: helm: Fix PDB apiVersion to allow K8s 1.25+ deployment
Posted by "jwitko (via GitHub)" <gi...@apache.org>.
jwitko commented on PR #13783:
URL: https://github.com/apache/druid/pull/13783#issuecomment-1431407437
Thanks @clintropolis @abhishekagarwal87 , sorry for missing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #13783: helm: Fix PDB apiVersion to allow K8s 1.25+ deployment
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on PR #13783:
URL: https://github.com/apache/druid/pull/13783#issuecomment-1431142973
> This is causing packaging check to fail.
fix https://github.com/apache/druid/pull/13810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #13783: helm: Fix PDB apiVersion to allow K8s 1.25+ deployment
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on PR #13783:
URL: https://github.com/apache/druid/pull/13783#issuecomment-1431153401
> I also created a PR - #13811
oops, missed that one, approved yours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #13783: helm: Fix PDB apiVersion to allow K8s 1.25+ deployment
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on PR #13783:
URL: https://github.com/apache/druid/pull/13783#issuecomment-1431154884
oh i guess I didn't miss it, mine was first 😅 , whatever, still closed mine and approved yours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13783: helm: Fix PDB apiVersion to allow K8s 1.25+ deployment
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #13783:
URL: https://github.com/apache/druid/pull/13783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #13783: helm: Fix PDB apiVersion to allow K8s 1.25+ deployment
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on PR #13783:
URL: https://github.com/apache/druid/pull/13783#issuecomment-1431149860
I also created a PR - https://github.com/apache/druid/pull/13811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tejaswini-imply commented on pull request #13783: helm: Fix PDB apiVersion to allow K8s 1.25+ deployment
Posted by "tejaswini-imply (via GitHub)" <gi...@apache.org>.
tejaswini-imply commented on PR #13783:
URL: https://github.com/apache/druid/pull/13783#issuecomment-1431109687
This is causing packaging check to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org