You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/10/25 19:36:50 UTC

[GitHub] rabbah commented on a change in pull request #4079: Fix controller logs in docker-machine

rabbah commented on a change in pull request #4079: Fix controller logs in docker-machine
URL: https://github.com/apache/incubator-openwhisk/pull/4079#discussion_r228307539
 
 

 ##########
 File path: ansible/roles/controller/tasks/deploy.yml
 ##########
 @@ -27,6 +27,14 @@
     mode: 0777
   become: "{{ logs.dir.become }}"
 
+# We need to create the file with proper permissions because the dir creation above
 
 Review comment:
   take a look at the lines just below - maybe we can consolidate both?
   i'm wondering if we should guard this for docker-machine env.
   @csantanapr thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services