You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "kamalesh0406 (via GitHub)" <gi...@apache.org> on 2023/04/02 22:28:59 UTC

[GitHub] [cassandra] kamalesh0406 opened a new pull request, #2258: CASSANDRA-18221: Add AccordConfig to track accord specific configs

kamalesh0406 opened a new pull request, #2258:
URL: https://github.com/apache/cassandra/pull/2258

   patch by Kamalesh Palanisamy;
   
   Thanks for sending a pull request! Here are some tips if you're new here:
    
    * Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
    * Be sure to keep the PR description updated to reflect all changes.
    * Write your PR title to summarize what this PR proposes.
    * If possible, provide a concise example to reproduce the issue for a faster review.
    * Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
    * If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
    
   Commit messages should follow the following format:
   
   ```
   <One sentence description, usually Jira title or CHANGES.txt summary>
   
   <Optional lengthier description (context on patch)>
   
   patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
   
   Co-authored-by: Name1 <email1>
   Co-authored-by: Name2 <email2>
   
   ```
   
   The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] dcapwell commented on a diff in pull request #2258: CASSANDRA-18221: Add AccordConfig to track accord specific configs

Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #2258:
URL: https://github.com/apache/cassandra/pull/2258#discussion_r1157521084


##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -137,7 +139,9 @@ private AccordService()
         this.messageSink = new AccordMessageSink();
         this.configService = new AccordConfigurationService(localId);
         this.scheduler = new AccordScheduler();
+        this.config = new AccordConfig(DatabaseDescriptor.getAccordSchedulerDelayInMS());

Review Comment:
   this pattern isn't something we can maintain; every new config comes with a massive burden to update this constructor; IMO we should push this logic into the YAML layer



##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -596,6 +596,7 @@ public MemtableOptions()
     public volatile boolean use_statements_enabled = true;
 
     public boolean accord_transactions_enabled = false;
+    public long accord_scheduler_delay_in_ms = 200L;

Review Comment:
   agree with this comment, `DurationSpec` (or one of the ones that limit the domain) is what we should do; `in_ms` should be avoided 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] Claudenw commented on a diff in pull request #2258: CASSANDRA-18221: Add AccordConfig to track accord specific configs

Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on code in PR #2258:
URL: https://github.com/apache/cassandra/pull/2258#discussion_r1156858145


##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -596,6 +596,7 @@ public MemtableOptions()
     public volatile boolean use_statements_enabled = true;
 
     public boolean accord_transactions_enabled = false;
+    public long accord_scheduler_delay_in_ms = 200L;

Review Comment:
   Shouldn't this be a DurationSpec rather than a long particularly if you expect very large values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] kamalesh0406 commented on a diff in pull request #2258: CASSANDRA-18221: Add AccordConfig to track accord specific configs

Posted by "kamalesh0406 (via GitHub)" <gi...@apache.org>.
kamalesh0406 commented on code in PR #2258:
URL: https://github.com/apache/cassandra/pull/2258#discussion_r1155385251


##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -596,6 +596,7 @@ public MemtableOptions()
     public volatile boolean use_statements_enabled = true;
 
     public boolean accord_transactions_enabled = false;
+    public long accord_scheduler_delay_in_ms = 200L;

Review Comment:
   This could also be named `accord_progress_log_scheduler_delay_in_ms` but I felt it to verbose compared to the current one. I am open to suggestions on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] kamalesh0406 closed pull request #2258: CASSANDRA-18221: Add AccordConfig to track accord specific configs

Posted by "kamalesh0406 (via GitHub)" <gi...@apache.org>.
kamalesh0406 closed pull request #2258: CASSANDRA-18221: Add AccordConfig to track accord specific configs
URL: https://github.com/apache/cassandra/pull/2258


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2258: CASSANDRA-18221: Add AccordConfig to track accord specific configs

Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2258:
URL: https://github.com/apache/cassandra/pull/2258#discussion_r1157763082


##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -596,6 +596,7 @@ public MemtableOptions()
     public volatile boolean use_statements_enabled = true;
 
     public boolean accord_transactions_enabled = false;
+    public long accord_scheduler_delay_in_ms = 200L;

Review Comment:
   @kamalesh0406 @dcapwell  is not this "wrong" way of doing it? There are no "...in_ms" properties anymore, everything is based on `DurationSpec` when it comes to time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org