You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amruth Sampath <am...@gmail.com> on 2015/08/19 13:17:39 UTC
Re: Review Request 37504: LENS-716 Support for !=,
in and not in predicates in elastic search driver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37504/
-----------------------------------------------------------
(Updated Aug. 19, 2015, 11:17 a.m.)
Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and sharad agarwal.
Repository: lens
Description
-------
Have added the support for predicated mentioned.
- in
- not in
- not equals
Have also made improvements to accomodate new predicates easily.
Diffs
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ASTTraverserForES.java 5e082e5
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriverConfig.java df01fe6
lens-driver-es/src/main/java/org/apache/lens/driver/es/grammar/Aggregations.java PRE-CREATION
lens-driver-es/src/main/java/org/apache/lens/driver/es/grammar/LogicalOperators.java PRE-CREATION
lens-driver-es/src/main/java/org/apache/lens/driver/es/grammar/Predicates.java PRE-CREATION
lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/ASTCriteriaVisitor.java a0bd7c8
lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/ASTVisitor.java f654a60
lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/impl/ESAggregateVisitor.java 69f20d3
lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/impl/ESCriteriaVisitor.java fbc606b
lens-driver-es/src/test/resources/valid-queries.data 982325c
Diff: https://reviews.apache.org/r/37504/diff/
Testing
-------
All test cases passed
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.307 s]
[INFO] Lens ............................................... SUCCESS [ 3.571 s]
[INFO] Lens API ........................................... SUCCESS [ 13.749 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 14.223 s]
[INFO] Lens Cube .......................................... SUCCESS [06:39 min]
[INFO] Lens DB storage .................................... SUCCESS [ 18.483 s]
[INFO] Lens Query Library ................................. SUCCESS [ 8.822 s]
[INFO] Lens Hive Driver ................................... SUCCESS [03:51 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.052 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 9.208 s]
[INFO] Lens Server ........................................ SUCCESS [12:23 min]
[INFO] Lens client ........................................ SUCCESS [ 27.267 s]
[INFO] Lens CLI ........................................... SUCCESS [03:42 min]
[INFO] Lens Examples ...................................... SUCCESS [ 2.152 s]
[INFO] Lens Distribution .................................. SUCCESS [ 24.760 s]
[INFO] Lens ML Lib ........................................ SUCCESS [02:05 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 8.703 s]
[INFO] Lens Regression .................................... SUCCESS [ 1.737 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:31 min
[INFO] Finished at: 2015-08-16T10:01:29+05:30
[INFO] Final Memory: 168M/992M
[INFO] ------------------------------------------------------------------------
Thanks,
Amruth Sampath
Re: Review Request 37504: LENS-716 Support for !=,
in and not in predicates in elastic search driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37504/#review95847
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 19, 2015, 11:17 a.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37504/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 11:17 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Have added the support for predicated mentioned.
> - in
> - not in
> - not equals
>
> Have also made improvements to accomodate new predicates easily.
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ASTTraverserForES.java 5e082e5
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriverConfig.java df01fe6
> lens-driver-es/src/main/java/org/apache/lens/driver/es/grammar/Aggregations.java PRE-CREATION
> lens-driver-es/src/main/java/org/apache/lens/driver/es/grammar/LogicalOperators.java PRE-CREATION
> lens-driver-es/src/main/java/org/apache/lens/driver/es/grammar/Predicates.java PRE-CREATION
> lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/ASTCriteriaVisitor.java a0bd7c8
> lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/ASTVisitor.java f654a60
> lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/impl/ESAggregateVisitor.java 69f20d3
> lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/impl/ESCriteriaVisitor.java fbc606b
> lens-driver-es/src/test/resources/valid-queries.data 982325c
>
> Diff: https://reviews.apache.org/r/37504/diff/
>
>
> Testing
> -------
>
> All test cases passed
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.307 s]
> [INFO] Lens ............................................... SUCCESS [ 3.571 s]
> [INFO] Lens API ........................................... SUCCESS [ 13.749 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 14.223 s]
> [INFO] Lens Cube .......................................... SUCCESS [06:39 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 18.483 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 8.822 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [03:51 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.052 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 9.208 s]
> [INFO] Lens Server ........................................ SUCCESS [12:23 min]
> [INFO] Lens client ........................................ SUCCESS [ 27.267 s]
> [INFO] Lens CLI ........................................... SUCCESS [03:42 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 2.152 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 24.760 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:05 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 8.703 s]
> [INFO] Lens Regression .................................... SUCCESS [ 1.737 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:31 min
> [INFO] Finished at: 2015-08-16T10:01:29+05:30
> [INFO] Final Memory: 168M/992M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amruth Sampath
>
>