[GitHub] [lucene-solr] aroopganguly commented on a change in pull request #1335: SOLR-14316 Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() method

[GitBox <gi...@apache.org>]

aroopganguly commented on a change in pull request #1335: SOLR-14316 Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() method
URL: https://github.com/apache/lucene-solr/pull/1335#discussion_r391184047
 
 

 ##########
 File path: solr/solrj/src/test/org/apache/solr/common/util/TestJavaBinCodec.java
 ##########
 @@ -287,6 +289,45 @@ public void testAllTypes() throws IOException {
     );
   }
 
+  @Test
+  public void testReadMapEntry() throws IOException {
+    Map.Entry<Object, Object> extryFromTextDoc1 = getMapFromJavaBinCodec(SOLRJ_DOCS_1);
+    Map.Entry<Object, Object> extryFromTextDoc1_clone = getMapFromJavaBinCodec(SOLRJ_DOCS_1);
+
+    Map.Entry<Object, Object> extryFromTextDoc2 = getMapFromJavaBinCodec(SOLRJ_DOCS_2);
+    Map.Entry<Object, Object> extryFromTextDoc2_clone = getMapFromJavaBinCodec(SOLRJ_DOCS_2);
+
+    // exactly same document read twice should have same content
+    assert (extryFromTextDoc1.equals(extryFromTextDoc1_clone));
 
 Review comment:
   sure !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org