You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/09 12:11:22 UTC
[GitHub] [flink] mxm opened a new pull request #10811: [FLINK-15504] Allow
output to stdout/stderr during execution of PackagedProgram
mxm opened a new pull request #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
We suppress the output to stdout/stderr during plan extraction via
PackagedProgram. This has unintended consequences for users who are looking into
debugging their Flink programs during JobGraph creation.
## Brief change log
This change removes the suppression of output when we run the JARs. The plan
preview still suppresses the output to avoid spaming the logs during plan
preview.
## Verifying this change
This change added tests and can be verified as follows:
Please see `JarHandlerTest` and `OptimizerPlanEnvironmentTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
- The S3 file system connector: (no )
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #10811:
[FLINK-15504] Allow output to stdout/stderr during execution of
PackagedProgram
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#discussion_r364782822
##########
File path: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarHandlerTest.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.webmonitor.handlers;
+
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.RestOptions;
+import org.apache.flink.configuration.WebOptions;
+import org.apache.flink.runtime.rest.RestClient;
+import org.apache.flink.runtime.rest.RestClientConfiguration;
+import org.apache.flink.runtime.rest.messages.MessageHeaders;
+import org.apache.flink.runtime.rest.util.RestClientException;
+import org.apache.flink.runtime.testingUtils.TestingUtils;
+import org.apache.flink.runtime.testutils.MiniClusterResource;
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
+import org.apache.flink.testutils.junit.category.AlsoRunWithLegacyScheduler;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.net.URI;
+import java.nio.file.FileSystem;
+import java.nio.file.FileSystems;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.HashMap;
+import java.util.Optional;
+
+import static org.hamcrest.CoreMatchers.containsString;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+/**
+ * Tests for the {@link JarRunHandler} and {@link JarPlanHandler}.
+ */
+@Category(AlsoRunWithLegacyScheduler.class)
+public class JarHandlerTest extends TestLogger {
+
+ @ClassRule
+ public static final TemporaryFolder TMP = new TemporaryFolder();
+
+ enum Type {
+ PLAN,
+ RUN
+ }
+
+ @Test
+ public void testPlanJar() throws Exception {
+ runTest(Type.PLAN, "hello out!", "hello err!");
+ }
+
+ @Test
+ public void testRunJar() throws Exception {
+ runTest(Type.RUN, "(none)", "(none)");
+ }
+
+ private static void runTest(Type type, String expectedCapturedStdOut, String expectedCapturedStdErr) throws Exception {
+ Path uploadDir = TMP.newFolder().toPath();
+
+ Path actualUploadDir = uploadDir.resolve("flink-web-upload");
+ Files.createDirectory(actualUploadDir);
+
+ Path emptyJar = actualUploadDir.resolve("empty.jar");
+ createJarFile(emptyJar);
+
+ Configuration config = new Configuration();
+ config.setString(WebOptions.UPLOAD_DIR, uploadDir.toString());
+
+ MiniClusterResource clusterResource = new MiniClusterResource(
+ new MiniClusterResourceConfiguration.Builder()
+ .setConfiguration(config)
+ .setNumberTaskManagers(1)
+ .setNumberSlotsPerTaskManager(1)
+ .build());
+ clusterResource.before();
+
+ try {
+ Configuration clientConfig = clusterResource.getClientConfiguration();
+ RestClient client = new RestClient(RestClientConfiguration.fromConfiguration(clientConfig), TestingUtils.defaultExecutor());
+
+ try {
+ final MessageHeaders headers;
+ final JarMessageParameters parameters;
+ if (type == Type.RUN) {
+ headers = JarRunHeaders.getInstance();
+ parameters = ((JarRunHeaders) headers).getUnresolvedMessageParameters();
+ } else if (type == Type.PLAN) {
+ headers = JarPlanGetHeaders.getInstance();
+ parameters = ((JarPlanGetHeaders) headers).getUnresolvedMessageParameters();
+ } else {
+ throw new RuntimeException("Invalid type: " + type);
+ }
+ parameters.jarIdPathParameter.resolve(emptyJar.getFileName().toString());
+
+ String host = clientConfig.getString(RestOptions.ADDRESS);
+ int port = clientConfig.getInteger(RestOptions.PORT);
+
+ try {
+ client.sendRequest(host, port, headers, parameters, new JarPlanRequestBody())
+ .get();
+ } catch (Exception e) {
+ Optional<RestClientException> expected = ExceptionUtils.findThrowable(e, RestClientException.class);
+ if (expected.isPresent()) {
+ // implies the job was actually submitted
+ assertThat(expected.get().getMessage(), containsString("ProgramInvocationException"));
+ // original cause is preserved in stack trace
+ assertThat(expected.get().getMessage(), containsString("The program plan could not be fetched - the program aborted pre-maturely"));
+ // implies the jar was registered for the job graph (otherwise the jar name would not occur in the exception)
+ // implies the jar was uploaded (otherwise the file would not be found at all)
+ assertThat(expected.get().getMessage(), containsString("empty.jar"));
+ // ensure that no stdout/stderr has been captured
+ assertThat(expected.get().getMessage(), containsString("System.out: " + expectedCapturedStdOut));
+ assertThat(expected.get().getMessage(), containsString("System.err: " + expectedCapturedStdErr));
+ } else {
+ throw e;
+ }
+ }
+ } finally {
+ client.shutdown(Time.milliseconds(10));
+ }
+ } finally {
+ clusterResource.after();
+ }
+ }
+
+ private static void createJarFile(Path zipFile) throws IOException {
+ URI uri = URI.create("jar:file:" + zipFile.toString());
+ HashMap<String, Object> env = new HashMap<>();
+ // We need this to ensure the file will be created if it does not exist
+ env.put("create", "true");
+ try (FileSystem zipfs = FileSystems.newFileSystem(uri, env)) {
+ Files.createDirectory(zipfs.getPath("META-INF"));
+ Path manifest = zipfs.getPath("META-INF/MANIFEST.MF");
+ Files.write(manifest, "Manifest-Version: 1.0\nCreated-By: Apache Flink\nMain-Class: HelloWorld\n".getBytes());
+
+ Path content = zipfs.getPath("HelloWorld.class");
+ Files.write(content, new byte[] {
+ // A program that prints 'hello out!' to stdout and 'hello err!' to stderr
Review comment:
Could you add the actual code as a comment in order to be able to regenerate this byte array?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10811: [FLINK-15504]
Allow output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572540427
<!--
Meta data
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723314 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727692 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
-->
## CI report:
* 4ded7a2610974acbc983c9ca33965354ce2a1fa2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723314) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223)
* 1a2e22c93965b36d65fcdd8e8add514861a3ae7e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727692) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10811: [FLINK-15504]
Allow output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572540427
<!--
Meta data
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143723314 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
-->
## CI report:
* 4ded7a2610974acbc983c9ca33965354ce2a1fa2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143723314) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223)
* 1a2e22c93965b36d65fcdd8e8add514861a3ae7e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] mxm commented on a change in pull request #10811:
[FLINK-15504] Allow output to stdout/stderr during execution of
PackagedProgram
Posted by GitBox <gi...@apache.org>.
mxm commented on a change in pull request #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#discussion_r364825383
##########
File path: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarHandlerTest.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.webmonitor.handlers;
+
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.RestOptions;
+import org.apache.flink.configuration.WebOptions;
+import org.apache.flink.runtime.rest.RestClient;
+import org.apache.flink.runtime.rest.RestClientConfiguration;
+import org.apache.flink.runtime.rest.messages.MessageHeaders;
+import org.apache.flink.runtime.rest.util.RestClientException;
+import org.apache.flink.runtime.testingUtils.TestingUtils;
+import org.apache.flink.runtime.testutils.MiniClusterResource;
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
+import org.apache.flink.testutils.junit.category.AlsoRunWithLegacyScheduler;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.net.URI;
+import java.nio.file.FileSystem;
+import java.nio.file.FileSystems;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.HashMap;
+import java.util.Optional;
+
+import static org.hamcrest.CoreMatchers.containsString;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+/**
+ * Tests for the {@link JarRunHandler} and {@link JarPlanHandler}.
+ */
+@Category(AlsoRunWithLegacyScheduler.class)
+public class JarHandlerTest extends TestLogger {
+
+ @ClassRule
+ public static final TemporaryFolder TMP = new TemporaryFolder();
+
+ enum Type {
+ PLAN,
+ RUN
+ }
+
+ @Test
+ public void testPlanJar() throws Exception {
+ runTest(Type.PLAN, "hello out!", "hello err!");
+ }
+
+ @Test
+ public void testRunJar() throws Exception {
+ runTest(Type.RUN, "(none)", "(none)");
+ }
+
+ private static void runTest(Type type, String expectedCapturedStdOut, String expectedCapturedStdErr) throws Exception {
+ Path uploadDir = TMP.newFolder().toPath();
+
+ Path actualUploadDir = uploadDir.resolve("flink-web-upload");
+ Files.createDirectory(actualUploadDir);
+
+ Path emptyJar = actualUploadDir.resolve("empty.jar");
+ createJarFile(emptyJar);
+
+ Configuration config = new Configuration();
+ config.setString(WebOptions.UPLOAD_DIR, uploadDir.toString());
+
+ MiniClusterResource clusterResource = new MiniClusterResource(
+ new MiniClusterResourceConfiguration.Builder()
+ .setConfiguration(config)
+ .setNumberTaskManagers(1)
+ .setNumberSlotsPerTaskManager(1)
+ .build());
+ clusterResource.before();
+
+ try {
+ Configuration clientConfig = clusterResource.getClientConfiguration();
+ RestClient client = new RestClient(RestClientConfiguration.fromConfiguration(clientConfig), TestingUtils.defaultExecutor());
+
+ try {
+ final MessageHeaders headers;
+ final JarMessageParameters parameters;
+ if (type == Type.RUN) {
+ headers = JarRunHeaders.getInstance();
+ parameters = ((JarRunHeaders) headers).getUnresolvedMessageParameters();
+ } else if (type == Type.PLAN) {
+ headers = JarPlanGetHeaders.getInstance();
+ parameters = ((JarPlanGetHeaders) headers).getUnresolvedMessageParameters();
+ } else {
+ throw new RuntimeException("Invalid type: " + type);
+ }
+ parameters.jarIdPathParameter.resolve(emptyJar.getFileName().toString());
+
+ String host = clientConfig.getString(RestOptions.ADDRESS);
+ int port = clientConfig.getInteger(RestOptions.PORT);
+
+ try {
+ client.sendRequest(host, port, headers, parameters, new JarPlanRequestBody())
+ .get();
+ } catch (Exception e) {
+ Optional<RestClientException> expected = ExceptionUtils.findThrowable(e, RestClientException.class);
+ if (expected.isPresent()) {
+ // implies the job was actually submitted
+ assertThat(expected.get().getMessage(), containsString("ProgramInvocationException"));
+ // original cause is preserved in stack trace
+ assertThat(expected.get().getMessage(), containsString("The program plan could not be fetched - the program aborted pre-maturely"));
+ // implies the jar was registered for the job graph (otherwise the jar name would not occur in the exception)
+ // implies the jar was uploaded (otherwise the file would not be found at all)
+ assertThat(expected.get().getMessage(), containsString("empty.jar"));
+ // ensure that no stdout/stderr has been captured
+ assertThat(expected.get().getMessage(), containsString("System.out: " + expectedCapturedStdOut));
+ assertThat(expected.get().getMessage(), containsString("System.err: " + expectedCapturedStdErr));
+ } else {
+ throw e;
+ }
+ }
+ } finally {
+ client.shutdown(Time.milliseconds(10));
+ }
+ } finally {
+ clusterResource.after();
+ }
+ }
+
+ private static void createJarFile(Path zipFile) throws IOException {
+ URI uri = URI.create("jar:file:" + zipFile.toString());
+ HashMap<String, Object> env = new HashMap<>();
+ // We need this to ensure the file will be created if it does not exist
+ env.put("create", "true");
+ try (FileSystem zipfs = FileSystems.newFileSystem(uri, env)) {
+ Files.createDirectory(zipfs.getPath("META-INF"));
+ Path manifest = zipfs.getPath("META-INF/MANIFEST.MF");
+ Files.write(manifest, "Manifest-Version: 1.0\nCreated-By: Apache Flink\nMain-Class: HelloWorld\n".getBytes());
+
+ Path content = zipfs.getPath("HelloWorld.class");
+ Files.write(content, new byte[] {
+ // A program that prints 'hello out!' to stdout and 'hello err!' to stderr
Review comment:
That makes sense. I will add this code as a comment:
```java
public class HelloWorld {
public static void main(String[] args) {
System.out.println("hello out!");
System.err.println("hello err!");
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10811: [FLINK-15504] Allow
output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572540427
<!--
Meta data
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
-->
## CI report:
* 4ded7a2610974acbc983c9ca33965354ce2a1fa2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10811: [FLINK-15504]
Allow output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572540427
<!--
Meta data
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723314 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727692 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
-->
## CI report:
* 4ded7a2610974acbc983c9ca33965354ce2a1fa2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723314) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223)
* 1a2e22c93965b36d65fcdd8e8add514861a3ae7e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727692) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10811: [FLINK-15504]
Allow output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572540427
<!--
Meta data
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723314 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143727692 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:38d73b1c1ce2e263405d0e2036cf66117419346f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143764652 TriggerType:PUSH TriggerID:38d73b1c1ce2e263405d0e2036cf66117419346f
Hash:38d73b1c1ce2e263405d0e2036cf66117419346f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4237 TriggerType:PUSH TriggerID:38d73b1c1ce2e263405d0e2036cf66117419346f
-->
## CI report:
* 4ded7a2610974acbc983c9ca33965354ce2a1fa2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723314) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223)
* 1a2e22c93965b36d65fcdd8e8add514861a3ae7e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143727692) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226)
* 38d73b1c1ce2e263405d0e2036cf66117419346f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143764652) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4237)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10811: [FLINK-15504]
Allow output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572540427
<!--
Meta data
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723314 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143727692 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:38d73b1c1ce2e263405d0e2036cf66117419346f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:38d73b1c1ce2e263405d0e2036cf66117419346f
-->
## CI report:
* 4ded7a2610974acbc983c9ca33965354ce2a1fa2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723314) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223)
* 1a2e22c93965b36d65fcdd8e8add514861a3ae7e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143727692) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226)
* 38d73b1c1ce2e263405d0e2036cf66117419346f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] mxm commented on issue #10811: [FLINK-15504] Allow output
to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
mxm commented on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572637798
Thank you for the quick review! 🎉 I'll leave this open until tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10811: [FLINK-15504]
Allow output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572540427
<!--
Meta data
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723314 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143727692 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
-->
## CI report:
* 4ded7a2610974acbc983c9ca33965354ce2a1fa2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723314) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223)
* 1a2e22c93965b36d65fcdd8e8add514861a3ae7e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143727692) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10811: [FLINK-15504] Allow
output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572536116
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4ded7a2610974acbc983c9ca33965354ce2a1fa2 (Thu Jan 09 12:16:17 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10811: [FLINK-15504]
Allow output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572540427
<!--
Meta data
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723314 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727692 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
-->
## CI report:
* 4ded7a2610974acbc983c9ca33965354ce2a1fa2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723314) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223)
* 1a2e22c93965b36d65fcdd8e8add514861a3ae7e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727692) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] mxm merged pull request #10811: [FLINK-15504] Allow output
to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
mxm merged pull request #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10811: [FLINK-15504]
Allow output to stdout/stderr during execution of PackagedProgram
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10811: [FLINK-15504] Allow output to stdout/stderr during execution of PackagedProgram
URL: https://github.com/apache/flink/pull/10811#issuecomment-572540427
<!--
Meta data
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723314 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:4ded7a2610974acbc983c9ca33965354ce2a1fa2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223 TriggerType:PUSH TriggerID:4ded7a2610974acbc983c9ca33965354ce2a1fa2
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143727692 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:1a2e22c93965b36d65fcdd8e8add514861a3ae7e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226 TriggerType:PUSH TriggerID:1a2e22c93965b36d65fcdd8e8add514861a3ae7e
Hash:38d73b1c1ce2e263405d0e2036cf66117419346f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143764652 TriggerType:PUSH TriggerID:38d73b1c1ce2e263405d0e2036cf66117419346f
Hash:38d73b1c1ce2e263405d0e2036cf66117419346f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4237 TriggerType:PUSH TriggerID:38d73b1c1ce2e263405d0e2036cf66117419346f
-->
## CI report:
* 4ded7a2610974acbc983c9ca33965354ce2a1fa2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723314) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4223)
* 1a2e22c93965b36d65fcdd8e8add514861a3ae7e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143727692) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4226)
* 38d73b1c1ce2e263405d0e2036cf66117419346f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143764652) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4237)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services