[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1113: [HUDI-415] Get commit time when Spark start

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #1113: [HUDI-415] Get commit time when Spark start
URL: https://github.com/apache/incubator-hudi/pull/1113#discussion_r359173720
 
 

 ##########
 File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
 ##########
 @@ -145,7 +146,7 @@ private[hudi] object HoodieSparkSqlWriter {
         log.info("new batch has no new records, skipping...")
         return (true, common.util.Option.empty())
       }
-      commitTime = client.startCommit()
+      client.startCommitWithTime(commitTime)
 
 Review comment:
   @vinothchandar : does "rollbackPendingCommits" matter here? only diff I see between client.startCommit() and callingclient.startcommitWithTime(time) is rolling back pending commits. if that is not required in this path, this patch is good. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services