[GitHub] [zeppelin] Reamer commented on a change in pull request #4298: [ZEPPELIN-5660] Implement move gcsnotebookrepo folder

[GitBox <gi...@apache.org>]

Reamer commented on a change in pull request #4298:
URL: https://github.com/apache/zeppelin/pull/4298#discussion_r814559922



##########
File path: zeppelin-plugins/notebookrepo/gcs/src/test/java/org/apache/zeppelin/notebook/repo/GCSNotebookRepoTest.java
##########
@@ -187,6 +187,28 @@ public void testRemove() throws Exception {
     assertThat(storage.get(makeBlobId(runningNote.getId(), runningNote.getPath()))).isNull();
   }
 
+  @Test
+  public void testRemoveFolder_nonexistent() throws Exception {
+    try {
+      notebookRepo.remove("id", "/name", AUTH_INFO);
+      fail();
+    } catch (IOException e) {}

Review comment:
       try catch block is not necessary.

##########
File path: zeppelin-plugins/notebookrepo/gcs/src/test/java/org/apache/zeppelin/notebook/repo/GCSNotebookRepoTest.java
##########
@@ -202,6 +224,29 @@ public void testMove() throws Exception {
     assertThat(storage.get(makeBlobId(runningNote.getId(), runningNote.getPath()))).isNull();
   }
 
+  @Test
+  public void testMoveFolder_nonexistent() throws Exception {
+    try {
+      notebookRepo.move("/name", "/name_new", AUTH_INFO);
+      fail();
+    } catch (IOException e) {}

Review comment:
       try catch block is not necessary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org