You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "RongtongJin (via GitHub)" <gi...@apache.org> on 2024/11/16 10:42:25 UTC

[PR] [ISSUE #8942] Add incGroupAckNums and incGroupCkNums to LmqBrokerStatsManager [rocketmq]

RongtongJin opened a new pull request, #8943:
URL: https://github.com/apache/rocketmq/pull/8943

   <!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
   
   Fixes #8942
   - Add incGroupAckNums and incGroupCkNums to LmqBrokerStatsManager
   - Add a setBrokerStatsManager method to enhance extensibility, allowing for more fine-grained control to be implemented externally.
   **Alternatively, we could discuss the removal of the LmqBrokerStatsManager class, as it appears to have limited value in my opinion.**
   
   ### Brief Description
   
   <!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
   
   ### How Did You Test This Change?
   
   <!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #8942] Add incGroupAckNums and incGroupCkNums to LmqBrokerStatsManager [rocketmq]

Posted by "ltamber (via GitHub)" <gi...@apache.org>.
ltamber merged PR #8943:
URL: https://github.com/apache/rocketmq/pull/8943


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #8942] Add incGroupAckNums and incGroupCkNums to LmqBrokerStatsManager [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8943:
URL: https://github.com/apache/rocketmq/pull/8943#issuecomment-2480525689

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8943?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `0%` with `18 lines` in your changes missing coverage. Please review.
   > Project coverage is 47.54%. Comparing base [(`4574647`)](https://app.codecov.io/gh/apache/rocketmq/commit/4574647a3a20a17562a0d3fc34b1c8394cc53b8e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`04d2724`)](https://app.codecov.io/gh/apache/rocketmq/commit/04d272407d4a50881a75d9d9bfa6105b9bfd843e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/8943?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...he/rocketmq/store/stats/LmqBrokerStatsManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/8943?src=pr&el=tree&filepath=store%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fstore%2Fstats%2FLmqBrokerStatsManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3N0YXRzL0xtcUJyb2tlclN0YXRzTWFuYWdlci5qYXZh) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8943?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/rocketmq/broker/BrokerController.java](https://app.codecov.io/gh/apache/rocketmq/pull/8943?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2FBrokerController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8943?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             develop    #8943   +/-   ##
   ==========================================
     Coverage      47.53%   47.54%           
   + Complexity     11731    11730    -1     
   ==========================================
     Files           1304     1304           
     Lines          91058    91076   +18     
     Branches       11675    11679    +4     
   ==========================================
   + Hits           43288    43305   +17     
   + Misses         42426    42422    -4     
   - Partials        5344     5349    +5     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8943?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org