You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/08 12:13:36 UTC

[GitHub] zentol opened a new pull request #7057: [FLINK-10361][tests][ES] Properly wait for ES to start

zentol opened a new pull request #7057: [FLINK-10361][tests][ES] Properly wait for ES to start
URL: https://github.com/apache/flink/pull/7057
 
 
   ## What is the purpose of the change
   
   This PR fixes `elasticsearch-common.sh#wait_elasticsearch_working` not actually waiting for ES to start up.
   In light of the recent move towards `set -e` we no longer rely on the return code and instead grep the curl output for expected contents (the returned JSON contains a cluster_name field).
   If not present we continue looping.
   
   ## Verifying this change
   
   Locally verified by querying a bogus ports and ensuring that the test fails early.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services