You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by alexandrelimassantana <gi...@git.apache.org> on 2015/09/19 20:31:49 UTC
[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...
GitHub user alexandrelimassantana opened a pull request:
https://github.com/apache/cloudstack/pull/852
Removal of DefaultUserAuthenticator empty class.
The DefaultUserAuthenticator is an empty class, extending from the
AdapterBase and implementing the UserAuthenticator interface. The class
is not being used as a marker and it's sole use is to be extended by
other UserAuthenticators. Noticing that the class had no purpose, I
removed it and made it's children extend from it's superclass and
implement it's interface instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack master-lrg-cs-hackday-005
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #852
----
commit 91daba381d95ac4556a60db62799fdeee0da4445
Author: Alexandre de Limas Santana <al...@gmail.com>
Date: 2015-09-19T18:30:27Z
Removal of DefaultUserAuthenticator empty class.
The DefaultUserAuthenticator is an empty class, extending from the
AdapterBase and implementing the UserAuthenticator interface. The class
is not being used as a marker and it's sole use is to be extended by
other UserAuthenticators. Noticing that the class had no purpose, I
removed it and made it's children extend from it's superclass and
implement it's interface instead.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/852
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/852#issuecomment-147090501
LGTM, thanks for the cleanup :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/852#issuecomment-141721291
Nice work @alexandrelimassantana, the class “DefaultUserAuthenticator” does not bring anything new to the hierarchy. Moreover, it has a comment “Use this UserAuthenticator if users are already authenticated outside”, but it is an abstract class, there is no way to use that class the way it is. That class seems something that was left behind a long time ago.
I would just add, could you remove the @Local annotations on classes that you touched? They are not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---