You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/20 09:14:19 UTC
[GitHub] [ozone] ferhui opened a new pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
ferhui opened a new pull request #1823:
URL: https://github.com/apache/ozone/pull/1823
## What changes were proposed in this pull request?
Change metrics unit from nanosecond to millisecond uniformly
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4725
## How was this patch tested?
manual tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-764210287
Thanks @ferhui for you explanation! Let's see if other people have comments on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
ferhui commented on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-764152253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
ferhui commented on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-764152253
> So the reason to convert nano to millis is because that most of the unit are already millis?
>
> Could there be a reason that nano as unit actually could be better?
@amaliujia Thanks for comments. As mentioned in JIRA HDDS-4725, I think there are some reasons that it's better to use millis.
- Mostly the metrics are the order of millisecond.
- It's millis in hadoop, and It's easier to understand the metric.
- there are both nano and milli right now, we need to unify them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia edited a comment on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-763916294
So the reason to convert nano to millis is because that most of the unit are already millis?
Could there be a reason that nano as unit actually could be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia edited a comment on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-763916294
So the reason to convert nano to millis is because that most of the unit are already millis?
Could there be a reason that nano as unit actually could be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-763916294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
ferhui commented on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-765061186
@runzhiwang Thanks for review & merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] runzhiwang merged pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #1823:
URL: https://github.com/apache/ozone/pull/1823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
ferhui commented on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-763535433
@ChenSammi @elek Could you please take a look?Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] runzhiwang merged pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #1823:
URL: https://github.com/apache/ozone/pull/1823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ferhui commented on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
ferhui commented on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-765043168
@amaliujia Thanks for review! I will merge this if no other comments later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-763916294
So the reason to convert nano to millis is because that most of the unit are already millis?
Could there a reason that nano as unit actually could be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1823: HDDS-4725. Change metrics unit from nanosecond to millisecond
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1823:
URL: https://github.com/apache/ozone/pull/1823#issuecomment-764867920
+1 LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org