You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2018/02/01 10:54:20 UTC

[GitHub] flink pull request #5396: [FLINK-5820] [state backends] Split shared/exclusi...

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5396#discussion_r165295768
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointProperties.java ---
    @@ -18,45 +18,50 @@
     
     package org.apache.flink.runtime.checkpoint;
     
    +import org.apache.flink.annotation.VisibleForTesting;
     import org.apache.flink.runtime.jobgraph.JobStatus;
     
     import java.io.Serializable;
     
    +import static org.apache.flink.util.Preconditions.checkNotNull;
    +
     /**
    - * The configuration of a checkpoint, such as whether
    + * The configuration of a checkpoint. This described whether
      * <ul>
    - *     <li>The checkpoint should be persisted</li>
    - *     <li>The checkpoint must be full, or may be incremental (not yet implemented)</li>
    - *     <li>The checkpoint format must be the common (cross backend) format,
    - *     or may be state-backend specific (not yet implemented)</li>
    - *     <li>when the checkpoint should be garbage collected</li>
    + *     <li>The checkpoint is s regular checkpoint or a savepoint</li>
    + *     <li>When the checkpoint should be garbage collected</li>
      * </ul>
      */
     public class CheckpointProperties implements Serializable {
     
    -	private static final long serialVersionUID = -8835900655844879470L;
    +	private static final long serialVersionUID = 2L;
     
    -	private final boolean forced;
    +	/** Type - checkpoit / savepoint. */
    --- End diff --
    
    nit: typo


---